FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: remove removed apis from http2 docs by kjin · Pull Request #18439 · nodejs/node · GitHub

/ node Public

doc: remove removed apis from http2 docs - #18439

Closed
kjin wants to merge 2 commits into
nodejs:masterfrom
kjin:http2-docs-9.4
Closed

doc: remove removed apis from http2 docs#18439
kjin wants to merge 2 commits into
nodejs:masterfrom
kjin:http2-docs-9.4

Conversation

kjin commented Jan 29, 2018

Copy link
Copy Markdown
Contributor
  • Removed references to removed socketError event
  • Removed second definition of Http2Session#close (as far as I could tell in the implementation, close no longer accepts an options object)
  • Add parameter types for ClientHttp2Session 'altsvc' event
  • Re-ordered event names in Http2SecureServer to be alphabetical and added 'session' event (from Http2Server)
Checklist
Affected core subsystem(s)

doc

nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Jan 29, 2018
maclover7 requested a review from apapirovski January 31, 2018 21:45
BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 1, 2018

BridgeAR commented Feb 1, 2018

Copy link
Copy Markdown
Member

jasnell commented Feb 2, 2018

Copy link
Copy Markdown
Member

Looks like some linting issues.

kjin commented Feb 3, 2018

Copy link
Copy Markdown
Contributor Author

Oops, forgot to remove a ```. Thanks!

addaleax commented Feb 4, 2018

Copy link
Copy Markdown
Member

Landed in 71b15e8

addaleax closed this Feb 4, 2018
addaleax pushed a commit that referenced this pull request Feb 4, 2018
PR-URL: #18439
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
addaleax removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 4, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
PR-URL: #18439
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
PR-URL: #18439
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
PR-URL: #18439
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins mentioned this pull request Feb 21, 2018

Copy link
Copy Markdown
Contributor

Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

kjin added a commit to kjin/node that referenced this pull request May 1, 2018
PR-URL: nodejs#18439
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
Backport-PR-URL: #20456
PR-URL: #18439
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins mentioned this pull request May 2, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#18439
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL