FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark test-inspector-stop-profile-after-done flaky by MylesBorins · Pull Request #18491 · nodejs/node · GitHub

/ node Public

test: mark test-inspector-stop-profile-after-done flaky - #18491

Merged
MylesBorins merged 1 commit into
nodejs:masterfrom
MylesBorins:mark-flake
Feb 1, 2018
ConversationCommits (1)ChecksFiles changed
Merged

test: mark test-inspector-stop-profile-after-done flaky#18491
MylesBorins merged 1 commit into
nodejs:masterfrom
MylesBorins:mark-flake

Conversation

MylesBorins commented Feb 1, 2018

Copy link
Copy Markdown
Contributor

This test is consistently failing and making CI red.

Refs: #16772

MylesBorins requested a review from Trott February 1, 2018 00:03
nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 1, 2018

MylesBorins commented Feb 1, 2018

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/12865/

MylesBorins mentioned this pull request Feb 1, 2018
Closed

MylesBorins commented Feb 1, 2018

Copy link
Copy Markdown
Contributor Author

I would like to fast track this

joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 1, 2018

MylesBorins commented Feb 1, 2018

Copy link
Copy Markdown
Contributor Author

one more CI

https://ci.nodejs.org/job/node-test-pull-request/12873/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 1, 2018
test: mark test-inspector-stop-profile-after-done flaky
a36b47b 
This test is consistently failing and making CI red.

PR-URL: nodejs#18491
Refs: nodejs#16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins commented Feb 1, 2018

Copy link
Copy Markdown
Contributor Author

landed in a36b47b

MylesBorins closed this Feb 1, 2018
MylesBorins merged commit a36b47b into nodejs:master Feb 1, 2018
addaleax removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 4, 2018
MylesBorins added a commit that referenced this pull request Feb 7, 2018
test: mark test-inspector-stop-profile-after-done flaky
4746bbf 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Feb 7, 2018
test: mark test-inspector-stop-profile-after-done flaky
076ca9f 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Feb 7, 2018
Merged
MylesBorins added a commit that referenced this pull request Feb 11, 2018
test: mark test-inspector-stop-profile-after-done flaky
d97376f 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Feb 12, 2018
test: mark test-inspector-stop-profile-after-done flaky
69271a6 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Feb 13, 2018
test: mark test-inspector-stop-profile-after-done flaky
694828d 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Feb 20, 2018
test: mark test-inspector-stop-profile-after-done flaky
3d8db8b 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Feb 21, 2018
test: mark test-inspector-stop-profile-after-done flaky
ee2075f 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins added a commit that referenced this pull request Feb 21, 2018
test: mark test-inspector-stop-profile-after-done flaky
da0d776 
This test is consistently failing and making CI red.

PR-URL: #18491
Refs: #16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Feb 21, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
test: mark test-inspector-stop-profile-after-done flaky
ce23fb1 
This test is consistently failing and making CI red.

PR-URL: nodejs#18491
Refs: nodejs#16772
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins deleted the mark-flake branch October 29, 2020 14:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
Trott Awaiting requested review from Trott
+1 more reviewer
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL