doc: fix unassigned deprecation codes - #18492
Closed
jasnell wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
vsemozhetbyt
approved these changes
Feb 1, 2018
thefourtheye
approved these changes
Feb 1, 2018
Copy link
Copy Markdown
Contributor
|
Just making an observation. We have DEP0089 after DEP0086. |
Sorry, something went wrong.
tniessen
approved these changes
Feb 1, 2018
BridgeAR
approved these changes
Feb 1, 2018
cjihrig
approved these changes
Feb 1, 2018
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Missed when landing nodejs#18333
4 tasks
jasnell
added a commit
that referenced
this pull request
Feb 1, 2018
Missed when landing the original PRs PR-URL: #18492 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Missed when landing the original PRs PR-URL: nodejs#18492 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oopsie... Forgot to assign the deprecation code when landing #18333
Checklist
Affected core subsystem(s)
crypto, docs