FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: nodejs/modules team now exists by devsnek · Pull Request #18545 · nodejs/node · GitHub

/ node Public

doc: nodejs/modules team now exists - #18545

Closed
devsnek wants to merge 1 commit into
nodejs:masterfrom
devsnek:patch-4
ConversationCommits (1)ChecksFiles changed
Closed

doc: nodejs/modules team now exists#18545
devsnek wants to merge 1 commit into
nodejs:masterfrom
devsnek:patch-4

Conversation

devsnek commented Feb 3, 2018

Copy link
Copy Markdown
Member

the nodejs/modules team has been created, changes who to ping for es modules

Checklist
Affected core subsystem(s)

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 3, 2018

targos commented Feb 3, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

There is @nodejs/esm for that. @nodejs/modules is more generally for the modules working group (maybe we should rename it @nodejs/modules-wg).

devsnek commented Feb 3, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

@targos will these two teams be consolidated or kept separate? (what should i do with this pr)

targos commented Feb 3, 2018

Copy link
Copy Markdown
Member

I don't know. If the people of the new team are all OK to be cc'd for every module issue or PR in core, we can remove nodejs/esm

joyeecheung commented Feb 3, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

cc @nodejs/esm are you in favor of merging @nodejs/esm into @nodejs/modules ?

BTW we can also make @nodejs/esm a child team of @nodejs/modules if people don't want to be cc'd for other module issues, although given that we want to make ESM interoperable with CJS modules, most issues of CJS modules also need to be considered by ESM and the fixes should be kept in sync whenever reasonable.

jdalton commented Feb 3, 2018

Copy link
Copy Markdown
Member

I'm cool with getting pinged for all things module (cjs/esm/node/wasm)

giltayar commented Feb 3, 2018

Copy link
Copy Markdown
Contributor

I'm probably not understanding what I'm getting into :-), but for me getting cc-ed on every module issue/PR would actually be a great way to get into things quickly.

joyeecheung reviewed Feb 3, 2018
View reviewed changes
Comment thread doc/onboarding-extras.md Outdated

joyeecheung Feb 3, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If we are talking about all things module...maybe this can be more specific, e.g. putting it down as lib/{internal/}module.js and src/module_wrap.*?

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 3, 2018

BridgeAR commented Feb 3, 2018

Copy link
Copy Markdown
Member

Mini-CI https://ci.nodejs.org/job/node-test-commit-light/211/

@devsnek would you be so kind and always trigger a CI after opening a PR? :-)

devsnek commented Feb 3, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

@BridgeAR can i do that yet? i haven't actually joined as a node collab yet, ci page doesn't show anything to let me start a run.

BridgeAR commented Feb 3, 2018

Copy link
Copy Markdown
Member

Oh, I see. In that case no. I thought that would already be the case.

mhdawson approved these changes Feb 5, 2018
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

BridgeAR commented Feb 6, 2018

Copy link
Copy Markdown
Member

Landed in 9686d87

BridgeAR closed this Feb 6, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 6, 2018
doc: update onboarding-extras
9686d87 
Mention the new modules team.

PR-URL: nodejs#18545
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
targos removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 6, 2018
devsnek deleted the patch-4 branch February 6, 2018 13:33
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
doc: update onboarding-extras
0557bec 
Mention the new modules team.

PR-URL: #18545
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
doc: update onboarding-extras
7cb5a7f 
Mention the new modules team.

PR-URL: #18545
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
doc: update onboarding-extras
7a432c1 
Mention the new modules team.

PR-URL: #18545
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
MylesBorins mentioned this pull request Feb 21, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
doc: update onboarding-extras
dff49fa 
Mention the new modules team.

PR-URL: nodejs#18545
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joyeecheung joyeecheung left review comments
ljharb ljharb approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
BridgeAR BridgeAR approved these changes
+5 more reviewers
bmeck bmeck approved these changes
TimothyGu TimothyGu approved these changes
targos targos approved these changes
hiroppy hiroppy approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL