FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: suppress unused warning postmortem_metadata by danbev · Pull Request #18557 · nodejs/node · GitHub

/ node Public

test: suppress unused warning postmortem_metadata - #18557

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:unused_warning_test_postmortem
Closed

test: suppress unused warning postmortem_metadata#18557
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:unused_warning_test_postmortem

Conversation

danbev commented Feb 4, 2018

Copy link
Copy Markdown
Contributor

Currently the following warning is generated by when building the
cctests:

../test/cctest/test_node_postmortem_metadata.cc:133:13:
warning: unused variable 'it' [-Wunused-variable]
  for (auto it : *(*env)->req_wrap_queue()) {}
            ^
1 warning generated.

This commmit adds a cast to void to suppres the warning.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Currently the following warning is generated by when building the
cctests:
../test/cctest/test_node_postmortem_metadata.cc:133:13:
warning: unused variable 'it' [-Wunused-variable]
  for (auto it : *(*env)->req_wrap_queue()) {}
            ^
1 warning generated.

This commmit adds a cast to void to suppres the warning.
nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 4, 2018

danbev commented Feb 4, 2018

Copy link
Copy Markdown
Contributor Author

cjihrig commented Feb 4, 2018

Copy link
Copy Markdown
Contributor

Duplicate of #18530?

danbev commented Feb 4, 2018

Copy link
Copy Markdown
Contributor Author

@cjihrig It is, sorry about that.

danbev closed this Feb 4, 2018
danbev deleted the unused_warning_test_postmortem branch February 28, 2018 07:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL