test: fix flaky test-http2-session-unref - #18589
Closed
apapirovski wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This test should exit naturally or will timeout on its own, a separate unrefed timer is not necessary.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
mhdawson
approved these changes
Feb 5, 2018
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, maybe a stress run would be good as well ?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Stress test CI: https://ci.nodejs.org/job/node-stress-single-test/1775/ (OS X as it's a good mix of building fast enough and being prone to being flaky due to being a slower box, compared to something like raspberry PI) |
Sorry, something went wrong.
jasnell
approved these changes
Feb 6, 2018
hiroppy
approved these changes
Feb 6, 2018
BridgeAR
approved these changes
Feb 6, 2018
cjihrig
approved these changes
Feb 6, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 7, 2018
This test should exit naturally or will timeout on its own, a separate unrefed timer is not necessary. PR-URL: nodejs#18589 Fixes: nodejs#18587 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
This test should exit naturally or will timeout on its own, a separate unrefed timer is not necessary. PR-URL: #18589 Fixes: #18587 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
This test should exit naturally or will timeout on its own, a separate unrefed timer is not necessary. PR-URL: #18589 Fixes: #18587 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
This test should exit naturally or will timeout on its own, a separate unrefed timer is not necessary. PR-URL: #18589 Fixes: #18587 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This test should exit naturally or will timeout on its own, a separate unrefed timer is not necessary. PR-URL: nodejs#18589 Fixes: nodejs#18587 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test should exit naturally or will timeout on its own, a separate unrefed timer is not necessary.
Fixes: #18587
Checklist
Affected core subsystem(s)
test