esm: revert format name to "cjs" over "commonjs" - #18596
Closed
guybedford wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
targos
approved these changes
Feb 6, 2018
devsnek
approved these changes
Feb 6, 2018
cjihrig
approved these changes
Feb 6, 2018
jasnell
approved these changes
Feb 6, 2018
TimothyGu
approved these changes
Feb 6, 2018
jdalton
approved these changes
Feb 6, 2018
MylesBorins
approved these changes
Feb 6, 2018
MylesBorins
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
We should fast track
Sorry, something went wrong.
BridgeAR
approved these changes
Feb 6, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 7, 2018
PR-URL: nodejs#18596 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 20, 2018
PR-URL: #18596 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Copy link
Copy Markdown
Contributor
|
Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
This should definitely be backported for consistency. Sure will work on this. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Actually this only needs to be backported if #16874 is backported. |
Sorry, something went wrong.
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18596 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the change originally made in #16874, returning the "format" name to "cjs" instead of "commonjs".
There was some complaint over consistency of the new name form, so if we do want to change this should aim to get it in before that gets released.
Note the documentation change has already been released here, while the code change hasn't yet.
//cc @devsnek @MylesBorins @targos @jdalton
Checklist
Affected core subsystem(s)
esm