FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: mark NAPI_AUTO_LENGTH as code by tniessen · Pull Request #18697 · nodejs/node · GitHub

/ node Public

doc: mark NAPI_AUTO_LENGTH as code - #18697

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:doc-napi-auto-length-backticks
ConversationCommits (1)ChecksFiles changed
Closed

doc: mark NAPI_AUTO_LENGTH as code#18697
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:doc-napi-auto-length-backticks

Conversation

tniessen commented Feb 10, 2018

Copy link
Copy Markdown
Member

This constant should be formatted as code.

Checklist
Affected core subsystem(s)

doc

nodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v4.x node-api Issues and PRs related to the Node-API. labels Feb 10, 2018
BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 10, 2018

BridgeAR commented Feb 10, 2018

Copy link
Copy Markdown
Member

I do not trigger a CI because it is clear that the current change will not fail.

tniessen commented Feb 10, 2018

Copy link
Copy Markdown
Member Author

I triggered a linter before creating the PR: https://ci.nodejs.org/job/node-test-linter/16022/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 10, 2018
lpinca approved these changes Feb 11, 2018
View reviewed changes
Comment thread doc/api/n-api.md
- `[in] message`: The message associated with the error.
- `[in] message_len`: The length of the message in bytes, or
NAPI_AUTO_LENGTH if it is
`NAPI_AUTO_LENGTH` if it is

lpinca Feb 11, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Unrelated nit: the line break seems unnecessary here.

tniessen commented Feb 11, 2018

Copy link
Copy Markdown
Member Author

Landed in a1bab82.

tniessen closed this Feb 11, 2018
tniessen added a commit that referenced this pull request Feb 11, 2018
doc: mark NAPI_AUTO_LENGTH as code
a1bab82 
PR-URL: #18697
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
doc: mark NAPI_AUTO_LENGTH as code
3bf8481 
PR-URL: #18697
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
doc: mark NAPI_AUTO_LENGTH as code
368c378 
PR-URL: #18697
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
doc: mark NAPI_AUTO_LENGTH as code
b5e09c4 
PR-URL: #18697
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
doc: mark NAPI_AUTO_LENGTH as code
b5073a0 
PR-URL: #18697
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 12, 2018
doc: mark NAPI_AUTO_LENGTH as code
5ab4d31 
PR-URL: nodejs#18697
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
doc: mark NAPI_AUTO_LENGTH as code
7996463 
PR-URL: nodejs#18697
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
doc: mark NAPI_AUTO_LENGTH as code
8826f18 
Backport-PR-URL: #19447
PR-URL: #18697
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Apr 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 1, 2018
doc: mark NAPI_AUTO_LENGTH as code
87d0fd8 
Backport-PR-URL: #19265
PR-URL: #18697
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
doc: mark NAPI_AUTO_LENGTH as code
beacfa7 
PR-URL: nodejs#18697
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tniessen removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Sep 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
Fishrock123 Fishrock123 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL