FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Refactor test-tls-pause by juggernaut451 · Pull Request #18714 · nodejs/node · GitHub

/ node Public

Refactor test-tls-pause - #18714

Closed
juggernaut451 wants to merge 3 commits into
nodejs:masterfrom
juggernaut451:refactor
ConversationCommits (3)ChecksFiles changed
Closed

Refactor test-tls-pause#18714
juggernaut451 wants to merge 3 commits into
nodejs:masterfrom
juggernaut451:refactor

Conversation

juggernaut451 commented Feb 11, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Changes that are done in file are :

nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 11, 2018
starkwang approved these changes Feb 13, 2018
View reviewed changes

starkwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Trott reviewed Feb 14, 2018
View reviewed changes
Comment thread test/parallel/test-tls-pause.js Outdated
common.skip('missing crypto');

// This test ensures that the data received over tls-server after pause
// is same as what it was send

Trott Feb 14, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: send -> sent.

juggernaut451 Feb 14, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

changes done

juggernaut451 Feb 16, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@Trott Thanks for feedback!

richardlau reviewed Feb 14, 2018
View reviewed changes
Comment thread test/parallel/test-tls-pause.js Outdated
}));

server.listen(0, function() {
server.listen(0, () => {

richardlau Feb 14, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The callback to listen could (should?) also be wrapped in common.mustCall.

juggernaut451 Feb 14, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

changes done

jasnell commented Feb 16, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/13206/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 16, 2018

BridgeAR commented Feb 17, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/13241/

BridgeAR commented Feb 17, 2018

Copy link
Copy Markdown
Member

Landed in c9b42c4 🎉

BridgeAR closed this Feb 17, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 17, 2018
test: refactor parallel/test-tls-pause
c9b42c4 
Use arrow functions and common.mustCall() and add a description.

PR-URL: nodejs#18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
test: refactor parallel/test-tls-pause
e7a415d 
Use arrow functions and common.mustCall() and add a description.

PR-URL: #18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
test: refactor parallel/test-tls-pause
72484e5 
Use arrow functions and common.mustCall() and add a description.

PR-URL: #18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
test: refactor parallel/test-tls-pause
d73f214 
Use arrow functions and common.mustCall() and add a description.

PR-URL: #18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
test: refactor parallel/test-tls-pause
b909318 
Use arrow functions and common.mustCall() and add a description.

PR-URL: nodejs#18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
test: refactor parallel/test-tls-pause
e5130db 
Use arrow functions and common.mustCall() and add a description.

PR-URL: #18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
test: refactor parallel/test-tls-pause
b197422 
Use arrow functions and common.mustCall() and add a description.

PR-URL: #18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
test: refactor parallel/test-tls-pause
ecd8659 
Use arrow functions and common.mustCall() and add a description.

PR-URL: #18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
test: refactor parallel/test-tls-pause
ffa7b50 
Use arrow functions and common.mustCall() and add a description.

PR-URL: #18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
jasnell jasnell approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes
richardlau richardlau approved these changes
+3 more reviewers
daynin daynin approved these changes
hiroppy hiroppy approved these changes
starkwang starkwang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL