tools: enable no-unsafe-finally - #18745
Closed
BridgeAR wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This enables the `no-unsafe-finally` eslint rule to make sure we have a proper control flow in try / catch.
bnoordhuis
approved these changes
Feb 13, 2018
Comment thread
test/common/index.js
Outdated
| const output = execSync(`${whoamiPath} /priv`, { timout: 1000 }); | ||
| if (!output.includes('SeCreateSymbolicLinkPrivilege')) { | ||
| return false; | ||
| } |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Can be simplified to just this, I think?
return output.includes('SeCreateSymbolicLinkPrivilege');And then you don't need the return true a few lines below.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Yepp, absolutely
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
cjihrig
approved these changes
Feb 13, 2018
lpinca
approved these changes
Feb 13, 2018
jasnell
approved these changes
Feb 13, 2018
mmarchini
approved these changes
Feb 15, 2018
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Feb 16, 2018
This enables the `no-unsafe-finally` eslint rule to make sure we have a proper control flow in try / catch. PR-URL: nodejs#18745 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Contributor
|
There is another unsafe finally in v9.x, would you be willing to manually backport and fix it so we can review? |
Sorry, something went wrong.
4 tasks
Copy link
Copy Markdown
Member
Author
|
Backported in #19244 that removed the other unsafe finally as well. |
Sorry, something went wrong.
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 21, 2018
This enables the `no-unsafe-finally` eslint rule to make sure we have a proper control flow in try / catch. PR-URL: nodejs#18745 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2018
This enables the `no-unsafe-finally` eslint rule to make sure we have a proper control flow in try / catch. Backport-PR-URL: #19244 PR-URL: #18745 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This enables the `no-unsafe-finally` eslint rule to make sure we have a proper control flow in try / catch. PR-URL: nodejs#18745 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Contributor
|
Backport requested for 8.x in #19244 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the no-unsafe-finally eslint rule to make sure we
have a proper control flow in try / catch.
Checklist
Affected core subsystem(s)
tools