FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Refactor of test-tls-over-http-tunnel by juggernaut451 · Pull Request #18784 · nodejs/node · GitHub

/ node Public

Refactor of test-tls-over-http-tunnel - #18784

Closed
juggernaut451 wants to merge 2 commits into
nodejs:masterfrom
juggernaut451:refactorTlsOverHttpTunnel
ConversationCommits (2)ChecksFiles changed
Closed

Refactor of test-tls-over-http-tunnel#18784
juggernaut451 wants to merge 2 commits into
nodejs:masterfrom
juggernaut451:refactorTlsOverHttpTunnel

Conversation

juggernaut451 commented Feb 14, 2018

Copy link
Copy Markdown
Contributor
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Changes that are done in file are :

  • replaced function with arrow function
  • adding descripiton about test
  • repalced callback with common.mustCall

#14544

nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 14, 2018
Trott reviewed Feb 15, 2018
View reviewed changes
Comment thread test/parallel/test-tls-over-http-tunnel.js Outdated
if (!common.hasCrypto)
common.skip('missing crypto');

// This test ensures that the data throught tls over http tunnel

Trott Feb 15, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Typo: throught -> through

Also, probably data received through rather than just data through?

juggernaut451 Feb 16, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

changes made. Thank you @Trott for feedback

jasnell commented Feb 16, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/13208/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 16, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 16, 2018
test: refactor of test-tls-over-http-tunnel
2960096 
PR-URL: nodejs#18784
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

BridgeAR commented Feb 16, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Landed in 2960096 🎉

@juggernaut451 I fixed the commit message while landing. Please check our commit guidelines briefly. They are always included as default text when opening a PR. Those checkboxes should actually also be checked accordingly :-)

BridgeAR closed this Feb 16, 2018

juggernaut451 commented Feb 16, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@BridgeAR will read it and will keep check from next time.

MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
test: refactor of test-tls-over-http-tunnel
91fd98b 
PR-URL: #18784
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
test: refactor of test-tls-over-http-tunnel
b3b5ac5 
PR-URL: #18784
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
test: refactor of test-tls-over-http-tunnel
95e070f 
PR-URL: nodejs#18784
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
test: refactor of test-tls-over-http-tunnel
0ef0dbc 
PR-URL: #18784
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
jasnell jasnell approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
danbev danbev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL