FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: remove extra space in README.md by mmarchini · Pull Request #18822 · nodejs/node · GitHub

/ node Public

doc: remove extra space in README.md - #18822

Closed
mmarchini wants to merge 1 commit into
nodejs:masterfrom
mmarchini:fix-readme-collab
Closed

doc: remove extra space in README.md#18822
mmarchini wants to merge 1 commit into
nodejs:masterfrom
mmarchini:fix-readme-collab

Conversation

Copy link
Copy Markdown
Contributor

Extra spaces in the Collaborators List will break node-core-utils's get-metadata.

Checklist
Affected core subsystem(s)

doc

mmarchini added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 16, 2018
nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 16, 2018
BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 16, 2018

Copy link
Copy Markdown
Member

Running a CI should not be necessary here.

Copy link
Copy Markdown
Contributor Author

Landed in f25104e

mmarchini pushed a commit that referenced this pull request Feb 16, 2018
PR-URL: #18822
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

ChALkeR commented Feb 16, 2018

Copy link
Copy Markdown
Member

Closing as it's landed.

ChALkeR closed this Feb 16, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
PR-URL: #18822
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins mentioned this pull request Feb 21, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
PR-URL: #18822
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#18822
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
PR-URL: #18822
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
PR-URL: #18822
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
PR-URL: #18822
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins mentioned this pull request Aug 16, 2018
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
PR-URL: #18822
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL