FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: add sync methods, deprecate optional callbacks by jonathanong · Pull Request #189 · nodejs/node · GitHub

  1. nodejs
  2. node

Repository navigation

crypto: add sync methods, deprecate optional callbacks - #189

Closed
jonathanong wants to merge 1 commit into
nodejs:v0.12from
jonathanong:crypto-async
ConversationCommits (1)ChecksFiles changed
Closed

crypto: add sync methods, deprecate optional callbacks#189
jonathanong wants to merge 1 commit into
nodejs:v0.12from
jonathanong:crypto-async

Conversation

jonathanong commented Dec 21, 2014

Copy link
Copy Markdown
Contributor

See #5

  • would you like me to add/change tests?
  • didn't bother disallowing callbacks in the sync version. after all this is about the public API. is that something you guys want?
  • want doc updates?
  • only changed .randomBytes() and .pseudoRandomBytes(). were there others?

piscisaureus reopened this Dec 30, 2014

piscisaureus commented Jan 10, 2015

Copy link
Copy Markdown
Contributor

I like this. @iojs/tc

trevnorris commented Jan 13, 2015

Copy link
Copy Markdown
Contributor

+1

ruimarinho commented Jan 13, 2015

Copy link
Copy Markdown

Someone mentioned on another issue (I can't find right now) that we should consider aligning our crypto API with the WebCryptoAPI, specifically using getRandomValues. I think it was an excellent idea. Would this be the moment to consider it?

trevnorris commented Jan 13, 2015

Copy link
Copy Markdown
Contributor

@ruimarinho Since 1.0.0-alpha is pushing for release, not right now. Though if there's not an official issue open asking for it then the issue should be created.

piscisaureus commented Jan 13, 2015

Copy link
Copy Markdown
Contributor

@jonathanong

only changed .randomBytes() and .pseudoRandomBytes(). were there others?

Yes, crypto.pbkdf2
Edit: I'm actually no so sure the callback is optional there.

charmander reviewed Jan 14, 2015
View reviewed changes
Comment thread lib/crypto.js

charmander Jan 14, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

“Please us” → “Please use” for these last two messages.

jonathanong commented Jan 23, 2015

Copy link
Copy Markdown
Contributor Author

what's the status on this? if desired, i can rebase and reopen for v1.x

brendanashworth commented Jan 27, 2015

Copy link
Copy Markdown
Contributor

I'm pretty sure doc updates would be a necessity to merge this in, but I don't believe a rebase and reopen is necessary, as a contributor would merge it manually anyways (unless there are merge conflicts). I could be corrected on that.

jonathanong mentioned this pull request Jan 28, 2015
Closed
1 task done
snyk-bot mentioned this pull request Jan 8, 2020
Open
snyk-bot mentioned this pull request Jul 5, 2020
Open
snyk-bot mentioned this pull request Aug 11, 2020
Open
snyk-bot mentioned this pull request Aug 27, 2020
Open
snyk-bot mentioned this pull request Jan 10, 2021
Merged
trongham mentioned this pull request Feb 25, 2021
Open
snyk-bot mentioned this pull request Jun 28, 2021
Open
This was referenced Jul 21, 2021
Open
Open
snyk-bot mentioned this pull request Aug 11, 2021
Open
This was referenced Sep 23, 2021
Open
Open
Open
snyk-bot mentioned this pull request Nov 14, 2021
Open
snyk-bot mentioned this pull request Dec 21, 2021
Open
This was referenced Jan 12, 2022
Open
Open
snyk-bot mentioned this pull request Jan 20, 2023
Open
This was referenced Feb 14, 2023
Open
Closed
snyk-bot mentioned this pull request Mar 15, 2023
Open
snyk-bot mentioned this pull request Mar 22, 2023
Open
ashly1111111 mentioned this pull request May 5, 2023
Open
snyk-bot mentioned this pull request May 5, 2023
Open
nicholaschoi168 mentioned this pull request May 16, 2023
Open
ashly1111111 mentioned this pull request Jun 1, 2023
Open
pranathi-nallamilli mentioned this pull request Aug 5, 2023
Open
ashly1111111 mentioned this pull request Sep 13, 2023
Open
JCsomeShots mentioned this pull request Sep 19, 2023
Open
maverick3312 mentioned this pull request Sep 28, 2023
Open
kingjay66 mentioned this pull request Oct 15, 2023
Open
Jingyi090 mentioned this pull request Nov 17, 2023
Open
nickfnblum mentioned this pull request Nov 21, 2023
Open
ashly1111111 mentioned this pull request Nov 24, 2023
Open
aravindb26 mentioned this pull request Jan 4, 2024
Open
CxsLucyfer mentioned this pull request Jan 29, 2024
Open
gr00nd mentioned this pull request Feb 6, 2024
Open
ahamedislam mentioned this pull request Feb 22, 2024
Open
DanyRay420 mentioned this pull request Feb 24, 2024
Open
matrix-compute mentioned this pull request Mar 28, 2024
Open
ashly1111111 mentioned this pull request Mar 29, 2024
Open
lairortega mentioned this pull request Apr 14, 2024
Open
yaseenaljamal mentioned this pull request Apr 25, 2024
Open
dannybrown13 mentioned this pull request May 7, 2024
Open
CharliesAngel1 mentioned this pull request May 7, 2024
Open
snyk-io Bot mentioned this pull request May 21, 2024
Open
syg pushed a commit to syg/node that referenced this pull request Jun 20, 2024
Make test-http-server-keepalive-req-gc robust to GC heuristics (nodej…
00b17b5 
…s#186) (nodejs#189)

* Fix test-http-server-keepalive-req-gc

* Format

---------

Co-authored-by: Etienne Pierre-Doray <etipdoray@gmail.com>
Co-authored-by: Etienne Pierre-doray <etiennep@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL