FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

url: replace "magic" numbers by constants by daynin · Pull Request #19035 · nodejs/node · GitHub

/ node Public

url: replace "magic" numbers by constants - #19035

Closed
daynin wants to merge 1 commit into
nodejs:masterfrom
daynin:url-add-constants
ConversationCommits (1)ChecksFiles changed
Closed

url: replace "magic" numbers by constants#19035
daynin wants to merge 1 commit into
nodejs:masterfrom
daynin:url-add-constants

Conversation

daynin commented Feb 27, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

url

nodejs-github-bot added the url Issues and PRs related to the legacy built-in url module. label Feb 27, 2018

watilde commented Feb 27, 2018

Copy link
Copy Markdown
Member

ci: https://ci.nodejs.org/job/node-test-pull-request/13398/

MylesBorins approved these changes Feb 27, 2018
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

rubber stamp LGTM if CI passes

cjihrig approved these changes Feb 28, 2018
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These changes LGTM, but it seems like there are still quite a few magic numbers in lib/url.js. For example, https://github.com/daynin/node/blob/32c3cb1c145a25efffb2f353d4db314b7952f6ca/lib/url.js#L276-L291

daynin commented Feb 28, 2018

Copy link
Copy Markdown
Contributor Author

@cjihrig I replaced remain numbers

daynin changed the title url: replace "magic" numbers by contstants url: replace "magic" numbers by constants Feb 28, 2018

watilde commented Feb 28, 2018

Copy link
Copy Markdown
Member

new ci: https://ci.nodejs.org/job/node-test-pull-request/13413/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 1, 2018
apapirovski approved these changes Mar 4, 2018
View reviewed changes

apapirovski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM but there's an incorrect comment that has to be fixed before landing.

Comment thread lib/internal/constants.js Outdated

apapirovski Mar 4, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This should be commented as \uFEFF, not \u00A0.

daynin Mar 4, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@apapirovski fixed

apapirovski removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 4, 2018
daynin force-pushed the url-add-constants branch from ccc8b07 to 44d723b Compare March 4, 2018 16:00

daynin commented Mar 6, 2018

Copy link
Copy Markdown
Contributor Author

/cc @nodejs/collaborators

Hello! Run CI for this PR, please

devsnek added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 6, 2018

devsnek commented Mar 6, 2018

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/13529/

BridgeAR commented Mar 11, 2018

Copy link
Copy Markdown
Member

Landed in 2f74326 🎉

BridgeAR closed this Mar 11, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 11, 2018
url: replace "magic" numbers by constants
2f74326 
PR-URL: nodejs#19035
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
url: replace "magic" numbers by constants
4ff060e 
PR-URL: #19035
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
url: replace "magic" numbers by constants
072adfe 
PR-URL: #19035
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos mentioned this pull request Mar 20, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
url: replace "magic" numbers by constants
9b23c55 
PR-URL: nodejs#19035
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

jasnell commented Aug 17, 2018

Copy link
Copy Markdown
Member

should this be backported to 8.x? If so, a separate backport PR is needed.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
watilde watilde approved these changes
cjihrig cjihrig approved these changes
tniessen tniessen approved these changes
+4 more reviewers
apapirovski apapirovski approved these changes
danbev danbev approved these changes
MylesBorins MylesBorins approved these changes
XadillaX XadillaX approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL