FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

next: Update v8 to 4.3.61.27 by targos · Pull Request #1909 · nodejs/node · GitHub

/ node Public

next: Update v8 to 4.3.61.27 - #1909

Closed
targos wants to merge 2 commits into
nodejs:nextfrom
targos:next-v8-27
ConversationCommits (2)ChecksFiles changed
Closed

next: Update v8 to 4.3.61.27#1909
targos wants to merge 2 commits into
nodejs:nextfrom
targos:next-v8-27

Conversation

targos commented Jun 6, 2015

Copy link
Copy Markdown
Member

targos and others added 2 commits June 6, 2015 08:59
deps: upgrade v8 to 4.3.61.27
2b67ca5
deps: backport 1f8555 from v8's upstream
9745eca 
Original commit message:

    api: introduce SealHandleScope

    When debugging Handle leaks in io.js we found it very convenient to be
    able to Seal some specific (root in our case) scope to prevent Handle
    allocations in it, and easily find leakage.

    R=yangguo
    BUG=

    Review URL: https://codereview.chromium.org/1079713002

    Cr-Commit-Position: refs/heads/master@{nodejs#27766}

Should help us identify and fix Handle leaks in core and user-space code.

NOTE: Works only in Debug build now, but is still better than nothing.

PR-URL: nodejs#1395
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
mscdex added the v8 engine Issues and PRs related to the V8 dependency. label Jun 6, 2015

Fishrock123 commented Jun 10, 2015

Copy link
Copy Markdown
Contributor

cc @bnoordhuis

trevnorris commented Jun 10, 2015

Copy link
Copy Markdown
Contributor

Not near my laptop or would do it myself, but let's kick off a CI. Change looks pretty straight forward.

cjihrig commented Jun 10, 2015

Copy link
Copy Markdown
Contributor

CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/794/

targos commented Jun 15, 2015

Copy link
Copy Markdown
Member Author

New URL: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi_old/794/
Anything possibly related in the failing tests?

trevnorris commented Jun 17, 2015

Copy link
Copy Markdown
Contributor

@chrisdickinson Please always leave a reason for closing.

trevnorris reopened this Jun 17, 2015

targos commented Jun 19, 2015

Copy link
Copy Markdown
Member Author

I'll close it myself in favor of the upgrade to V8 4.4: #1807 (comment)

targos closed this Jun 19, 2015

chrisdickinson commented Jun 19, 2015

Copy link
Copy Markdown
Contributor

Ah, this was likely automatically closed by GitHub when I recut next. Sorry I missed it.

On Jun 16, 2015, at 9:27 PM, Trevor Norris notifications@github.com wrote:

@chrisdickinson Please always leave a reason for closing.

—
Reply to this email directly or view it on GitHub.

targos deleted the next-v8-27 branch July 17, 2015 21:01
snyk-bot mentioned this pull request Aug 11, 2020
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL