FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test : refactor parallel/test-tls-ca-concat.js by juggernaut451 · Pull Request #19092 · nodejs/node · GitHub

/ node Public

test : refactor parallel/test-tls-ca-concat.js - #19092

Closed
juggernaut451 wants to merge 1 commit into
nodejs:masterfrom
juggernaut451:refactorTestTlsCaConcat
ConversationCommits (1)ChecksFiles changed
Closed

test : refactor parallel/test-tls-ca-concat.js#19092
juggernaut451 wants to merge 1 commit into
nodejs:masterfrom
juggernaut451:refactorTestTlsCaConcat

Conversation

juggernaut451 commented Mar 2, 2018

Copy link
Copy Markdown
Contributor

Implementing common.mustCall and changing the function to arrow function

Fixes : #14544

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 2, 2018
juggernaut451 force-pushed the refactorTestTlsCaConcat branch from e012117 to 0c3bbff Compare March 2, 2018 18:39

jasnell commented Mar 5, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/13507/

test: refactor parallel/test-tls-ca-concat.js
ee77247 
Implementing common.mustCall and changing the function to arrow function

Fixes : nodejs#14544
juggernaut451 force-pushed the refactorTestTlsCaConcat branch from 0c3bbff to ee77247 Compare March 7, 2018 20:08

juggernaut451 commented Mar 14, 2018

Copy link
Copy Markdown
Contributor Author

Resolved :)

tniessen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 14, 2018

tniessen commented Mar 14, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/13842/
New CI: https://ci.nodejs.org/job/node-test-pull-request/13674/

tniessen pushed a commit that referenced this pull request Mar 24, 2018
test: refactor parallel/test-tls-ca-concat.js
ca22c96 
PR-URL: #19092
Fixes: #14544
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

tniessen commented Mar 24, 2018

Copy link
Copy Markdown
Member

Landed in ca22c96.

tniessen closed this Mar 24, 2018
targos pushed a commit that referenced this pull request Mar 27, 2018
test: refactor parallel/test-tls-ca-concat.js
0310df8 
PR-URL: #19092
Fixes: #14544
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 3, 2018
test: refactor parallel/test-tls-ca-concat.js
146c488 
PR-URL: #19092
Fixes: #14544
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
tniessen tniessen approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL