| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager
|
Will create actual team and solicit membership once this PR lands (meaning we have agreed on the name) |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM but I do wonder if the description is clear enough for those that don't read the team description.
Sorry, something went wrong.
| | upgrading libuv | @saghul | | ||
| | upgrading npm | @fishrock123, @MylesBorins | | ||
| | upgrading V8 | @nodejs/v8, @nodejs/post-mortem | | ||
| | Embedded use or delivery of Node.js | @nodejs/delivery_channels | |
There was a problem hiding this comment.
Can we make sure that @nodejs/version-management becomes a child team of delivery_channels?
Sorry, something went wrong.
There was a problem hiding this comment.
Nit: Definitely not a fan of using _ when all our other teams use - to separate words. Let's not make people guess which punctuation to use with which team! :-D
Sorry, something went wrong.
There was a problem hiding this comment.
(We use _ where it's what a module is using, but otherwise, we use - as far as I can tell. So this should be -.)
Sorry, something went wrong.
There was a problem hiding this comment.
@ljharb will look to make it a subteam of the new team. Not exactly sure what that will take but I'll figure it out.
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM with nit addressed
Sorry, something went wrong.
Sorry, something went wrong.
|
CI was good, landing. |
Sorry, something went wrong.
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: #19098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: #19098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: #19098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: #19098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: #19098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: #19098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Add team that we can use to cc organizations or people who do one of the following: * bundle node into their product * bundle node into their distributions * provide an installer * provide a version manager PR-URL: nodejs#19098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
No need to land this in 8.x |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Add team that we can use to cc organizations or people
who do one of the following:
This would be the description I would add when creating the team itself:
This team is used to be able to communicate with organizations or people who do
one of the following:
If you are making a change to node core or elsewhere that might affect these parties
please include an @nodejs/delivery-channels in the issue.
Checklist
Affected core subsystem(s)
doc