FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: make suggestion more direct in stream.md by Trott · Pull Request #19124 · nodejs/node · GitHub

/ node Public

doc: make suggestion more direct in stream.md - #19124

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:in-general-1
ConversationCommits (1)ChecksFiles changed
Closed

doc: make suggestion more direct in stream.md#19124
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:in-general-1

Conversation

Trott commented Mar 4, 2018

Copy link
Copy Markdown
Member
Checklist
Affected core subsystem(s)

doc

Trott added the doc Issues and PRs related to the documentations. label Mar 4, 2018
nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Mar 4, 2018

Trott commented Mar 4, 2018

Copy link
Copy Markdown
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/206/

mscdex commented Mar 4, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

I think it would be better to explain why, because stream.read(n) is certainly a useful feature to have.

gibfahn reviewed Mar 4, 2018
View reviewed changes

gibfahn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but +1 to @mscdex 's suggestion.

Trott commented Mar 4, 2018

Copy link
Copy Markdown
Member Author

I think it would be better to explain why

Suggested text, anyone?

gibfahn commented Mar 5, 2018

Copy link
Copy Markdown
Member

Suggested text, anyone?

Yeah that's why it was a non-blocking suggestion (from me at least) 😁 .

mscdex commented Mar 5, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

The text seems to have been added by @jasnell in #6947. Quickly browsing that PR's reviews, it seems @chrisdickinson may have implicitly suggested its inclusion, although no reasoning was given behind the sentiment there either.

I think either the comment should be removed entirely or perhaps a reduced version of the comment should be used instead, one that promotes the use of pipe() (where possible) over manual 'data' event handlers or manual .read() invocations.

Trott commented Mar 7, 2018

Copy link
Copy Markdown
Member Author

Landed in cb5f9a6.

Will follow up on @mscdex's suggestion in a subsequent pull request.

Trott closed this Mar 7, 2018
Trott added a commit that referenced this pull request Mar 7, 2018
doc: make suggestion more direct in stream.md
cb5f9a6 
PR-URL: #19124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Mar 17, 2018
doc: make suggestion more direct in stream.md
187d5f2 
PR-URL: #19124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
doc: make suggestion more direct in stream.md
9ec0eab 
PR-URL: #19124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
doc: make suggestion more direct in stream.md
33323a3 
PR-URL: nodejs#19124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell pushed a commit to jasnell/node that referenced this pull request Aug 17, 2018
doc: make suggestion more direct in stream.md
2bb3600 
PR-URL: nodejs#19124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Sep 6, 2018
doc: make suggestion more direct in stream.md
1116d32 
Backport-PR-URL: #22380
PR-URL: #19124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins mentioned this pull request Sep 6, 2018
Merged
Trott deleted the in-general-1 branch January 13, 2022 22:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
gibfahn gibfahn left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL