test: minor refactoring - #19130
Closed
ken23421 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
change to arrow functions
cjihrig
approved these changes
Mar 4, 2018
gireeshpunathil
approved these changes
Mar 5, 2018
gibfahn
approved these changes
Mar 5, 2018
Copy link
Copy Markdown
Member
|
Looks good, but needs a manual test as CI doesn't test internet tests. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
tniessen
approved these changes
Mar 5, 2018
Copy link
Copy Markdown
Contributor
Author
|
@gibfahn Thanks for your comment. I tested it with the following command, and the result looks ok. $ python tools/test.py -J --mode=release test/internet/test-http-https-default-ports
[00:01|% 100|+ 1|- 0]: DoneDo you have other suggestion of the manual test? Thank you. |
Sorry, something went wrong.
jasnell
approved these changes
Mar 5, 2018
Copy link
Copy Markdown
Member
Nope that's perfect, just wanted to make sure someone had tried it. Thanks! |
Sorry, something went wrong.
maclover7
approved these changes
Mar 6, 2018
BridgeAR
approved these changes
Mar 6, 2018
Copy link
Copy Markdown
Contributor
Author
|
Thanks @gibfahn |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Landing... |
Sorry, something went wrong.
gibfahn
pushed a commit
that referenced
this pull request
Mar 9, 2018
Use arrow functions. PR-URL: #19130 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Copy link
Copy Markdown
Member
|
@ken23421 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@gibfahn Thanks a lot for your help :) |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Mar 17, 2018
Use arrow functions. PR-URL: #19130 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
Use arrow functions. PR-URL: #19130 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Use arrow functions. PR-URL: nodejs#19130 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Aug 17, 2018
Use arrow functions. PR-URL: nodejs#19130 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 6, 2018
Use arrow functions. Backport-PR-URL: #22380 PR-URL: #19130 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change to arrow functions
Checklist
Affected core subsystem(s)
test