FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v8.x backport] build: make linters independent of local node by joyeecheung · Pull Request #19190 · nodejs/node · GitHub

/ node Public

[v8.x backport] build: make linters independent of local node - #19190

Closed
joyeecheung wants to merge 2 commits into
nodejs:v8.x-stagingfrom
joyeecheung:backport-18272-to-v8.x
ConversationCommits (2)ChecksFiles changed
Closed

[v8.x backport] build: make linters independent of local node#19190
joyeecheung wants to merge 2 commits into
nodejs:v8.x-stagingfrom
joyeecheung:backport-18272-to-v8.x

Conversation

joyeecheung commented Mar 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Refs: #18272

build: make lint-md independent of local node
126aefb 
PR-URL: nodejs#18272
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
build: make lint-js independent of local node
4526a07 
PR-URL: nodejs#18272
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot added build Issues and PRs related to build files or the CI. v8.x labels Mar 6, 2018

joyeecheung commented Mar 7, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13557/

MylesBorins commented Mar 21, 2018

Copy link
Copy Markdown
Contributor

one more ci: https://ci.nodejs.org/job/node-test-pull-request/13785/

gibfahn self-assigned this Mar 26, 2018

BethGriggs commented Mar 27, 2018

Copy link
Copy Markdown
Member

CI 3: https://ci.nodejs.org/job/node-test-commit/17202/

MylesBorins force-pushed the v8.x-staging branch 2 times, most recently from 44cb0d3 to 16bf5fe Compare March 30, 2018 03:28

joyeecheung commented Mar 30, 2018

Copy link
Copy Markdown
Member Author

CI failures appear to be unrelated

gibfahn commented Apr 3, 2018

Copy link
Copy Markdown
Member

New CI to see what's going on here: https://ci.nodejs.org/job/node-test-commit/17394/

BethGriggs pushed a commit that referenced this pull request Apr 10, 2018
build: make lint-md independent of local node
d537f45 
PR-URL: #18272
Backport-PR-URL: #19190
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 10, 2018
build: make lint-js independent of local node
333d7dd 
PR-URL: #18272
Backport-PR-URL: #19190
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs commented Apr 10, 2018

Copy link
Copy Markdown
Member

Landed in 016a28a...333d7dd.

BethGriggs closed this Apr 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BethGriggs BethGriggs approved these changes
+1 more reviewer
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

gibfahn

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL