[8.x] src: fix util abort - #19224
Closed
BridgeAR wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This makes sure util.isRegExp and util.isDate will not abort in case more than one argument is passed to the function.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This has not yet landed on v9.x, so please hold off until the next release |
Sorry, something went wrong.
MylesBorins
force-pushed
the
v8.x-staging
branch
2 times, most recently
from
44cb0d3 to
16bf5fe
Compare
March 30, 2018 03:28
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
I'm not following, isn't this the same change as 8181c60, and thus a straight backport? EDIT: nvm, worked it out. |
Sorry, something went wrong.
gibfahn
approved these changes
Apr 13, 2018
gibfahn
pushed a commit
that referenced
this pull request
Apr 13, 2018
This makes sure util.isRegExp and util.isDate will not abort in case more than one argument is passed to the function. PR-URL: #19224 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure util.isRegExp and util.isDate will not abort in case
more than one argument is passed to the function.
This got fixed in #18415 in 10.x. So this is a direct fix for 8.x instead of a backport. I also opened #19223 for 9.x.
Checklist