[v9.x backport] http2: callback valid check before closing request - #19229
Closed
trivikr wants to merge 1 commit into
Closed
[v9.x backport] http2: callback valid check before closing request#19229trivikr wants to merge 1 commit into
trivikr wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Do not close the request if callback is not a function, and throw ERR_INVALID_CALLBACK TypeError PR-URL: nodejs#19061 Fixes: nodejs#18855 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
3 tasks
MylesBorins
force-pushed
the
v9.x-staging
branch
3 times, most recently
from
d457b9d to
03c321a
Compare
March 20, 2018 11:56
Copy link
Copy Markdown
Contributor
|
the test from this PR appears to be failing. Can you please test locally to verify edit: changed above phrasing... did not mean to imply "can you please test before pushing" rather "please test to verify it is broken" |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
=== release test-http2-client-rststream-before-connect ===
Path: parallel/test-http2-client-rststream-before-connect
(node:3048) ExperimentalWarning: The http2 module is an experimental API.
assert.js:49
throw new AssertionError(obj);
^
AssertionError [ERR_ASSERTION]: 'The "code" argument is out of range' === 'The value of "code" is out of range.'
at Object.innerFn (/Users/mborins/code/node/v9.x/test/common/index.js:705:16)
at expectedException (assert.js:252:19)
at Function.throws (assert.js:297:16)
at Object.expectsError (/Users/mborins/code/node/v9.x/test/common/index.js:727:12)
at Http2Server.server.listen.common.mustCall (/Users/mborins/code/node/v9.x/test/parallel/test-http2-client-rststream-before-connect.js:21:10)
at Http2Server.<anonymous> (/Users/mborins/code/node/v9.x/test/common/index.js:477:15)
at Object.onceWrapper (events.js:272:13)
at Http2Server.emit (events.js:180:13)
at emitListeningNT (net.js:1372:10)
at process._tickCallback (internal/process/next_tick.js:114:19)
Command: out/Release/node /Users/mborins/code/node/v9.x/test/parallel/test-http2-client-rststream-before-connect.js
[00:00|% 100|+ 0|- 1]: Done
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
ping @trivikr. It looks like the message test needs to be adapted to v9.x |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The test is successful in my local workspace And the value for ERR_OUT_OF_RANGE hasn't changed in v9.x-staging branch https://github.com/nodejs/node/blob/v9.x-staging/lib/internal/errors.js#L689 However, it looks like the errors were updated in master branch in commit 6e1c25c cc: @BridgeAR |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@trivikr The test does not check for the right error message (it is different between master and v9.x). It's weird that it passes in your local workspace. |
Sorry, something went wrong.
MylesBorins
force-pushed
the
v9.x-staging
branch
2 times, most recently
from
305fe4c to
4844a26
Compare
March 28, 2018 16:23
targos
pushed a commit
that referenced
this pull request
Apr 4, 2018
Do not close the request if callback is not a function, and throw ERR_INVALID_CALLBACK TypeError Backport-PR-URL: #19229 PR-URL: #19061 Fixes: #18855 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
May 1, 2018
Do not close the request if callback is not a function, and throw ERR_INVALID_CALLBACK TypeError Backport-PR-URL: nodejs#19229 PR-URL: nodejs#19061 Fixes: nodejs#18855 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 2, 2018
Do not close the request if callback is not a function, and throw ERR_INVALID_CALLBACK TypeError Backport-PR-URL: #19229 Backport-PR-URL: #20456 PR-URL: #19061 Fixes: #18855 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 15, 2018
Do not close the request if callback is not a function, and throw ERR_INVALID_CALLBACK TypeError Backport-PR-URL: #19229 Backport-PR-URL: #20456 PR-URL: #19061 Fixes: #18855 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 15, 2018
Do not close the request if callback is not a function, and throw ERR_INVALID_CALLBACK TypeError Backport-PR-URL: #19229 Backport-PR-URL: #20456 PR-URL: #19061 Fixes: #18855 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not close the request if callback is not a function, and
throw ERR_INVALID_CALLBACK TypeError
PR-URL: #19061
Fixes: #18855
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: Shingo Inoue leko.noor@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Checklist