FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix path in doctool/test-doctool-json by vsemozhetbyt · Pull Request #19287 · nodejs/node · GitHub

/ node Public

test: fix path in doctool/test-doctool-json - #19287

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:test-doctool-json-fix-path
ConversationCommits (1)ChecksFiles changed
Closed

test: fix path in doctool/test-doctool-json#19287
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:test-doctool-json-fix-path

Conversation

vsemozhetbyt commented Mar 11, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This seems to slip in #17820

vsemozhetbyt added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 11, 2018
nodejs-github-bot added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Mar 11, 2018

vsemozhetbyt commented Mar 11, 2018

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13629/

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 11, 2018
vsemozhetbyt added a commit that referenced this pull request Mar 11, 2018
test: fix path in doctool/test-doctool-json
0048169 
PR-URL: #19287
Refs: #17820
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

vsemozhetbyt commented Mar 11, 2018

Copy link
Copy Markdown
Contributor Author

Landed in 0048169

vsemozhetbyt deleted the test-doctool-json-fix-path branch March 11, 2018 21:04
targos pushed a commit that referenced this pull request Mar 17, 2018
test: fix path in doctool/test-doctool-json
2d3ef5a 
PR-URL: #19287
Refs: #17820
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos mentioned this pull request Mar 18, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
test: fix path in doctool/test-doctool-json
84ae59e 
PR-URL: #19287
Refs: #17820
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
test: fix path in doctool/test-doctool-json
fc24f3f 
PR-URL: nodejs#19287
Refs: nodejs#17820
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs mentioned this pull request Oct 16, 2018
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL