doc: clarify default TLS handshake timeout - #19290
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Because the `handshakeTimeout` is in milliseconds, use that unit of measurement to express the default value.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
cjihrig
approved these changes
Mar 12, 2018
jasnell
approved these changes
Mar 12, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 14, 2018
Because the `handshakeTimeout` is in milliseconds, use that unit of measurement to express the default value. PR-URL: nodejs#19290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 17, 2018
Because the `handshakeTimeout` is in milliseconds, use that unit of measurement to express the default value. PR-URL: #19290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
Because the `handshakeTimeout` is in milliseconds, use that unit of measurement to express the default value. PR-URL: #19290 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the handshakeTimeout is in milliseconds, use that unit of
measurement to express the default value.
Checklist