FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: patch V8 to 6.5.254.38 by MylesBorins · Pull Request #19303 · nodejs/node · GitHub

/ node Public

deps: patch V8 to 6.5.254.38 - #19303

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:v8-6.5.254.36
ConversationCommits (1)ChecksFiles changed
Closed

deps: patch V8 to 6.5.254.38#19303
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:v8-6.5.254.36

Conversation

MylesBorins commented Mar 12, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Mar 12, 2018

MylesBorins commented Mar 12, 2018

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13644/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1261/

MylesBorins commented Mar 12, 2018

Copy link
Copy Markdown
Contributor Author

Looks like we have a failure on ppc-be
/cc @nodejs/platform-ppc @nodejs/v8

15:11:39 === cctest/test-run-wasm-simd/RunWasm_SimdLoadStoreLoad_compiled ===
15:11:39 --- stderr ---
15:11:39 Received signal 11 SEGV_MAPERR 000000000018
15:11:39 
15:11:39 ==== C stack trace ===============================

targos commented Mar 12, 2018

Copy link
Copy Markdown
Member

It's expected. ppc-be is unsupported since Node 8. We have to ignore this failure until the job is updated to stop running on this platform

Flarna commented Mar 13, 2018

Copy link
Copy Markdown
Member

If you could update to 6.5.254.37 instead #19200 would be fixed too...

Flarna mentioned this pull request Mar 13, 2018
Closed
1 task
MylesBorins changed the title deps: patch V8 to 6.5.254.36 deps: patch V8 to 6.5.254.38 Mar 13, 2018

MylesBorins commented Mar 13, 2018

Copy link
Copy Markdown
Contributor Author

bumped to 6.5.254.38
CI: https://ci.nodejs.org/job/node-test-pull-request/13662/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1263/

MylesBorins commented Mar 14, 2018

Copy link
Copy Markdown
Contributor Author

weird new failure on ppcle

not ok 654 parallel/test-http-client-timeout-agent
  ---
  duration_ms: 0.721
  severity: fail
  stack: |-
    res#0 data:0
    res#0 end
    res#2 data:2
    res#2 end
    res#4 data:4
    res#4 end
    res#6 data:6
    res#6 end
    res#8 data:8
    res#8 end
    res#10 data:10
    res#10 end
    res#12 data:12
    res#12 end
    res#14 data:14
    res#14 end
    res#16 data:16
    res#16 end
    res#18 data:18
    res#18 end
    res#20 data:20
    res#20 end
    res#22 data:22
    res#22 end
    res#24 data:24
    res#24 end
    res#26 data:26
    res#26 end
    res#28 data:28
    res#28 end
    req#1 timeout
    req#3 timeout
    req#5 timeout
    req#7 timeout
    req#9 timeout
    req#11 timeout
    req#13 timeout
    req#15 timeout
    req#17 timeout
    req#19 timeout
    req#21 timeout
    req#23 timeout
    req#25 timeout
    req#27 timeout
    req#29 timeout
    req#0 timeout
    req#28 close
    req#26 close
    req#24 close
    req#22 close
    req#20 close
    req#18 close
    req#16 close
    req#14 close
    req#12 close
    req#10 close
    req#8 close
    req#6 close
    req#4 close
    req#2 close
    req#0 close
    req#29 error
    req#29 close
    req#27 error
    req#27 close
    req#25 error
    req#25 close
    req#23 error
    req#23 close
    req#21 error
    req#21 close
    req#19 error
    req#19 close
    req#17 error
    req#17 close
    req#15 error
    req#15 close
    req#13 error
    req#13 close
    req#11 error
    req#11 close
    req#9 error
    req#9 close
    req#7 error
    req#7 close
    req#5 error
    req#5 close
    req#3 error
    req#3 close
    req#1 error
    req#1 close
    done=31 sent=30
    assert.js:80
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: timeout on http request called too much
        at process.<anonymous> (/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcle-ubuntu1404/test/parallel/test-http-client-timeout-agent.js:94:10)
        at process.emit (events.js:187:15)

/cc @nodejs/platform-ppc

MylesBorins commented Mar 14, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Run CI one more time to be safe

https://ci.nodejs.org/job/node-test-pull-request/13664/

ppc once more; https://ci.nodejs.org/job/node-test-commit-plinux/16045/

MylesBorins commented Mar 14, 2018

Copy link
Copy Markdown
Contributor Author

Extra PPC test passed. The failing ppc test for V8-CI is expected

Landed in 040dd24

MylesBorins added a commit that referenced this pull request Mar 14, 2018
deps: patch V8 to 6.5.254.38
040dd24 
PR-URL: #19303
Refs: v8/v8@6.5.254.31...6.5.254.38
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
+2 more reviewers
danbev danbev approved these changes
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL