FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http2: destroy() stream, upon errnoException by SirR4T · Pull Request #19389 · nodejs/node · GitHub

/ node Public

http2: destroy() stream, upon errnoException - #19389

Closed
SirR4T wants to merge 1 commit into
nodejs:masterfrom
SirR4T:useDestroyInHttp2
ConversationCommits (1)ChecksFiles changed
Closed

http2: destroy() stream, upon errnoException#19389
SirR4T wants to merge 1 commit into
nodejs:masterfrom
SirR4T:useDestroyInHttp2

Conversation

SirR4T commented Mar 16, 2018

Copy link
Copy Markdown

First steps towards #19060

Attempting to move lib/net and lib/http2/core towards similar API, for all work of reading and writing from underlying stream.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Mar 16, 2018
addaleax approved these changes Mar 16, 2018
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

mcollina approved these changes Mar 17, 2018
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 19, 2018

addaleax commented Mar 19, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/17005/

jasnell commented Mar 20, 2018

Copy link
Copy Markdown
Member

The failures in CI are related.

SirR4T commented Mar 20, 2018

Copy link
Copy Markdown
Author

@addaleax / @jasnell : did i break something here? How do i fix it?

addaleax commented Mar 23, 2018

Copy link
Copy Markdown
Member

I can’t see anything in the CI failures that strikes out as something related.

New CI: https://ci.nodejs.org/job/node-test-commit/17118/

addaleax mentioned this pull request Mar 23, 2018
Closed
4 tasks

addaleax commented Mar 23, 2018

Copy link
Copy Markdown
Member

Landed in 84afd6e 🎉

addaleax closed this Mar 23, 2018
addaleax removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 23, 2018
addaleax pushed a commit that referenced this pull request Mar 23, 2018
http2: destroy() stream, upon errnoException
84afd6e 
First steps towards #19060

PR-URL: #19389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Apr 2, 2018
http2: destroy() stream, upon errnoException
7b850a7 
First steps towards #19060

PR-URL: #19389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos mentioned this pull request Apr 4, 2018
Merged
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
http2: destroy() stream, upon errnoException
d932237 
First steps towards nodejs#19060

PR-URL: nodejs#19389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
http2: destroy() stream, upon errnoException
519b063 
First steps towards #19060

Backport-PR-URL: #20456
PR-URL: #19389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins mentioned this pull request May 2, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 15, 2018
http2: destroy() stream, upon errnoException
58a7fd0 
First steps towards #19060

Backport-PR-URL: #20456
PR-URL: #19389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
http2: destroy() stream, upon errnoException
eddf3a6 
First steps towards #19060

Backport-PR-URL: #20456
PR-URL: #19389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL