FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v9.x] doc: fix deprecation removed by mistake by targos · Pull Request #19482 · nodejs/node · GitHub

/ node Public

[v9.x] doc: fix deprecation removed by mistake - #19482

Closed
targos wants to merge 1 commit into
nodejs:v9.x-stagingfrom
targos:fix-doc-v9.x
Closed

[v9.x] doc: fix deprecation removed by mistake#19482
targos wants to merge 1 commit into
nodejs:v9.x-stagingfrom
targos:fix-doc-v9.x

Conversation

targos commented Mar 20, 2018

Copy link
Copy Markdown
Member

In bae5de1,
a deprecation (DEP0089) was added to the docs and another one (DEP0098)
was removed by mistake. This commit restores it.

Fixes #19428 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

In nodejs@bae5de1,
a deprecation (DEP0089) was added to the docs and another one (DEP0098)
was removed by mistake. This commit restores it.
targos added doc Issues and PRs related to the documentations. v9.x fast-track PRs that do not need to wait for 48 hours to land. labels Mar 20, 2018
nodejs-github-bot added doc Issues and PRs related to the documentations. v9.x labels Mar 20, 2018
targos changed the title doc: fix deprecation removed by mistake [v9.x] doc: fix deprecation removed by mistake Mar 20, 2018

targos commented Mar 20, 2018

Copy link
Copy Markdown
Member Author

@BridgeAR @MylesBorins

Copy link
Copy Markdown
Member

@targos thanks for fixing this. Seems like I removed that in the backport by mistake.

MylesBorins pushed a commit that referenced this pull request Mar 20, 2018
In bae5de1,
a deprecation (DEP0089) was added to the docs and another one (DEP0098)
was removed by mistake. This commit restores it.

PR-URL: #19482
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Copy link
Copy Markdown
Contributor

landed in a4c28d7

targos mentioned this pull request Mar 21, 2018
targos deleted the fix-doc-v9.x branch October 17, 2020 12:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL