FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: minor improvements to buffer.md by Trott · Pull Request #19547 · nodejs/node · GitHub

/ node Public

doc: minor improvements to buffer.md - #19547

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:minor-buffer-doc-fixes
Closed

doc: minor improvements to buffer.md#19547
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:minor-buffer-doc-fixes

Conversation

Trott commented Mar 23, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Mar 23, 2018

Trott commented Mar 23, 2018

Copy link
Copy Markdown
Member Author

lpinca added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 23, 2018
vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 23, 2018

trivikr commented Mar 24, 2018

Copy link
Copy Markdown
Member

Landed in f4f999f

trivikr closed this Mar 24, 2018
trivikr pushed a commit that referenced this pull request Mar 24, 2018
PR-URL: #19547
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
tniessen removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 24, 2018
targos pushed a commit that referenced this pull request Mar 27, 2018
PR-URL: #19547
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 3, 2018
PR-URL: #19547
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs mentioned this pull request Dec 4, 2018
Trott deleted the minor-buffer-doc-fixes branch January 13, 2022 22:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.


Back | FazBrowse Home | New Git URL