FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: fix nits in tools/doc/type-parser.js by vsemozhetbyt · Pull Request #19612 · nodejs/node · GitHub

/ node Public

tools: fix nits in tools/doc/type-parser.js - #19612

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:tools-doc-type-parser
ConversationCommits (1)ChecksFiles changed
Closed

tools: fix nits in tools/doc/type-parser.js#19612
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:tools-doc-type-parser

Conversation

vsemozhetbyt commented Mar 26, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Style nits:

  • Remove redundant variable.
  • Rename and regroup variables for consistency.
  • Rearrange export to reduce indentation level (unnecessarily increases diff, unfortunately).
  • Replace common function by arrow function in .forEach() argument.
  • Replace .indexOf() with .includes().
  • Unify string concatenation, replace with template strings.

HTML nit:

  • Remove extra line break in the output (reduces overall docs size by 78 KB).

Logic nit:

  • Throw when type slot is empty (on things like { }, { | type }, { type | }).

vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 26, 2018
nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Mar 26, 2018

vsemozhetbyt commented Mar 26, 2018

Copy link
Copy Markdown
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/341/

vsemozhetbyt added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 26, 2018
vsemozhetbyt added a commit that referenced this pull request Mar 28, 2018
tools: fix nits in tools/doc/type-parser.js
5d387e9 
PR-URL: #19612
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>

vsemozhetbyt commented Mar 28, 2018

Copy link
Copy Markdown
Contributor Author

Landed in 5d387e9

vsemozhetbyt deleted the tools-doc-type-parser branch March 28, 2018 08:14
targos pushed a commit that referenced this pull request Apr 2, 2018
tools: fix nits in tools/doc/type-parser.js
2c5d53f 
PR-URL: #19612
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
targos mentioned this pull request Apr 4, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
tools: fix nits in tools/doc/type-parser.js
eb5f085 
PR-URL: #19612
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
MylesBorins mentioned this pull request Aug 17, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

trivikr trivikr approved these changes
+2 more reviewers
Leko Leko approved these changes
XadillaX XadillaX approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL