FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: improve zero-fill-buffers text by Trott · Pull Request #19623 · nodejs/node · GitHub

/ node Public

doc: improve zero-fill-buffers text - #19623

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:zero-fill-buffers
Closed

doc: improve zero-fill-buffers text#19623
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:zero-fill-buffers

Conversation

Trott commented Mar 26, 2018

Copy link
Copy Markdown
Member
  • improve text for easier comprehension
  • clarify that performance impact is negative
  • remove superfluous "either" (should only be used when there are 2
    options anyway)
  • remove superfluous italics
  • line wrap at 80 chars
Checklist

* improve text for easier comprehension
* clarify that performance impact is *negative*
* remove superfluous "either" (should only be used when there are 2
  options anyway)
* remove superfluous italics
* line wrap at 80 chars
nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Mar 26, 2018

Trott commented Mar 26, 2018

Copy link
Copy Markdown
Member Author

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 26, 2018
vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 26, 2018

trivikr commented Mar 27, 2018

Copy link
Copy Markdown
Member

Previous CI was aborted.
New CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/347/

trivikr commented Mar 27, 2018

Copy link
Copy Markdown
Member

Landed in 8eca6b8

trivikr closed this Mar 27, 2018
trivikr pushed a commit that referenced this pull request Mar 27, 2018
* improve text for easier comprehension
* clarify that performance impact is *negative*
* remove superfluous "either" (should only be used when there are 2
  options anyway)
* remove superfluous italics
* line wrap at 80 chars

PR-URL: #19623
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
targos pushed a commit that referenced this pull request Apr 2, 2018
* improve text for easier comprehension
* clarify that performance impact is *negative*
* remove superfluous "either" (should only be used when there are 2
  options anyway)
* remove superfluous italics
* line wrap at 80 chars

PR-URL: #19623
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
targos mentioned this pull request Apr 4, 2018
Trott deleted the zero-fill-buffers branch January 13, 2022 22:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants


Back | FazBrowse Home | New Git URL