FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: fix comment nits in tools/doc/*.js files by vsemozhetbyt · Pull Request #19696 · nodejs/node · GitHub

/ node Public

tools: fix comment nits in tools/doc/*.js files - #19696

Closed
vsemozhetbyt wants to merge 3 commits into
nodejs:masterfrom
vsemozhetbyt:tools-doc-comments
ConversationCommits (3)ChecksFiles changed
Closed

tools: fix comment nits in tools/doc/*.js files#19696
vsemozhetbyt wants to merge 3 commits into
nodejs:masterfrom
vsemozhetbyt:tools-doc-comments

Conversation

vsemozhetbyt commented Mar 30, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
  • Unify first letters case.
  • Unify periods.
  • Delete excess spaces.
  • Add some blank lines as logical delimiters.
  • Remove obvious comments.
  • Combine short lines, rewrap lines more logically.
  • Fix typos.

tools: Fix comment nits in tools/doc/*.js files
5d21a89 
* Unify first letters case.
* Unify periods.
* Delete excess spaces.
* Add some blank lines as logical delimiters.
* Remove obvious comments.
* Combine short lines, rewrap lines more logically.
* Fix typos.
vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 30, 2018
nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Mar 30, 2018

vsemozhetbyt commented Mar 30, 2018

Copy link
Copy Markdown
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/364/

BridgeAR approved these changes Mar 30, 2018
View reviewed changes
Comment thread tools/doc/html.js Outdated
}

//XXX maybe put more stuff here?
// XXX Maybe put more stuff here?

BridgeAR Mar 30, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Suggestion: being on it, you might also change XXX to TODO.

vsemozhetbyt Mar 30, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done.

vsemozhetbyt commented Mar 30, 2018

Copy link
Copy Markdown
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/365/

vsemozhetbyt added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 30, 2018
richardlau reviewed Mar 30, 2018
View reviewed changes
Comment thread tools/doc/html.js Outdated
}

// Syscalls which appear in the docs, but which only exist in BSD / OSX
// Syscalls which appear in the docs, but which only exist in BSD / OSX.

richardlau Mar 30, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

macOS since we're changing this line?

vsemozhetbyt Mar 30, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done.

vsemozhetbyt commented Mar 30, 2018

Copy link
Copy Markdown
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/366/

vsemozhetbyt added a commit that referenced this pull request Mar 30, 2018
tools: fix comment nits in tools/doc/*.js files
b88477e 
* Unify first letters case.
* Unify periods.
* Delete excess spaces.
* Add some blank lines as logical delimiters.
* Remove obvious comments.
* Combine short lines, rewrap lines more logically.
* Fix typos.
* "XXX" -> "TODO:", OSX -> macOS.

PR-URL: #19696
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

vsemozhetbyt commented Mar 30, 2018

Copy link
Copy Markdown
Contributor Author

Landed in b88477e

vsemozhetbyt deleted the tools-doc-comments branch March 30, 2018 13:11
vsemozhetbyt changed the title tools: Fix comment nits in tools/doc/*.js files tools: fix comment nits in tools/doc/*.js files Mar 30, 2018
vsemozhetbyt mentioned this pull request Mar 30, 2018
Closed
2 tasks
targos pushed a commit that referenced this pull request Apr 2, 2018
tools: fix comment nits in tools/doc/*.js files
140611b 
* Unify first letters case.
* Unify periods.
* Delete excess spaces.
* Add some blank lines as logical delimiters.
* Remove obvious comments.
* Combine short lines, rewrap lines more logically.
* Fix typos.
* "XXX" -> "TODO:", OSX -> macOS.

PR-URL: #19696
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos mentioned this pull request Apr 4, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
tools: fix comment nits in tools/doc/*.js files
59b99e8 
* Unify first letters case.
* Unify periods.
* Delete excess spaces.
* Add some blank lines as logical delimiters.
* Remove obvious comments.
* Combine short lines, rewrap lines more logically.
* Fix typos.
* "XXX" -> "TODO:", OSX -> macOS.

PR-URL: #19696
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins mentioned this pull request Aug 17, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
Leko Leko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL