test: fix flaky test-cluster-send-handle-twice - #19700
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Use `common.mustCall()` to make sure connection callback runs exactly once. Use `connect` event instead of `setTimeout` to avoid test failing if timer runs before client is connected. Remove `cluster.worker.disconnect()` after `assert.fail()`. It is unreachable code that is unnecessary.
Copy link
Copy Markdown
Member
Author
|
Example failure of the current form of the test in CI: https://ci.nodejs.org/job/node-test-commit-freebsd/16565/nodes=freebsd10-64/console not ok 474 parallel/test-cluster-send-handle-twice
---
duration_ms: 120.28
severity: fail
stack: |-
timeout
... |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Failure of current form of test reproduced locally: $ tools/test.py -j 96 --repeat 192 test/parallel/test-cluster-send-handle-twice.js === release test-cluster-send-handle-twice === Path: parallel/test-cluster-send-handle-twice Command: out/Release/node /Users/trott/io.js/test/parallel/test-cluster-send-handle-twice.js --- TIMEOUT --- ... === release test-cluster-send-handle-twice === Path: parallel/test-cluster-send-handle-twice Command: out/Release/node /Users/trott/io.js/test/parallel/test-cluster-send-handle-twice.js --- TIMEOUT --- [04:01|% 100|+ 134|- 58]: Done $ |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Success of test in this PR locally: $ tools/test.py -j 96 --repeat 192 test/parallel/test-cluster-send-handle-twice.js
[00:17|% 100|+ 192|- 0]: Done
$ |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
BridgeAR
approved these changes
Mar 30, 2018
Comment thread
test/parallel/test-cluster-send-handle-twice.js
| process.send('send-handle-1', socket); | ||
| process.send('send-handle-2', socket); | ||
| }); | ||
| })); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is very likely tested for very very often already.
Sorry, something went wrong.
lpinca
approved these changes
Mar 30, 2018
trivikr
approved these changes
Mar 30, 2018
jasnell
approved these changes
Apr 1, 2018
Copy link
Copy Markdown
Member
Author
|
Single CI failure seems unrelated. Re-running just that task: https://ci.nodejs.org/job/node-test-commit-plinux/16508/ (EDIT: Re-run is green.) |
Sorry, something went wrong.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 2, 2018
Use `common.mustCall()` to make sure connection callback runs exactly once. Use `connect` event instead of `setTimeout` to avoid test failing if timer runs before client is connected. Remove `cluster.worker.disconnect()` after `assert.fail()`. It is unreachable code that is unnecessary. PR-URL: nodejs#19700 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 3, 2018
Use `common.mustCall()` to make sure connection callback runs exactly once. Use `connect` event instead of `setTimeout` to avoid test failing if timer runs before client is connected. Remove `cluster.worker.disconnect()` after `assert.fail()`. It is unreachable code that is unnecessary. PR-URL: #19700 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 4, 2018
Use `common.mustCall()` to make sure connection callback runs exactly once. Use `connect` event instead of `setTimeout` to avoid test failing if timer runs before client is connected. Remove `cluster.worker.disconnect()` after `assert.fail()`. It is unreachable code that is unnecessary. PR-URL: #19700 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Dec 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use common.mustCall() to make sure connection callback runs exactly
once.
Use connect event instead of setTimeout to avoid test failing if
timer runs before client is connected.
Remove cluster.worker.disconnect() after assert.fail(). It is
unreachable code that is unnecessary.
Checklist