test: test process.setuid for bad argument types - #19703
Closed
dsinecos wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
test process.setuid with an object as an argument. An equivalent test exists for process.seteuid Fixes: nodejs#19591
gireeshpunathil
approved these changes
Mar 30, 2018
Copy link
Copy Markdown
Member
Sorry, something went wrong.
cjihrig
approved these changes
Mar 30, 2018
trivikr
approved these changes
Mar 30, 2018
jasnell
approved these changes
Apr 1, 2018
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lpinca
pushed a commit
that referenced
this pull request
Apr 4, 2018
Test process.setuid with an object as an argument. An equivalent test exists for process.seteuid. PR-URL: #19703 Fixes: #19591 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 4, 2018
Test process.setuid with an object as an argument. An equivalent test exists for process.seteuid. PR-URL: #19703 Fixes: #19591 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 4, 2018
Test process.setuid with an object as an argument. An equivalent test exists for process.seteuid. PR-URL: #19703 Fixes: #19591 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Dec 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test process.setuid with an object as an argument. An equivalent test
exists for process.seteuid
Fixes: #19591
Checklist