FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

n-api: back up env before finalize by gabrielschulhof · Pull Request #19718 · nodejs/node · GitHub

/ node Public

n-api: back up env before finalize - #19718

Closed
gabrielschulhof wants to merge 1 commit into
nodejs:masterfrom
gabrielschulhof:n-api-back-up-env
ConversationCommits (1)ChecksFiles changed
Closed

n-api: back up env before finalize#19718
gabrielschulhof wants to merge 1 commit into
nodejs:masterfrom
gabrielschulhof:n-api-back-up-env

Conversation

gabrielschulhof commented Apr 1, 2018

Copy link
Copy Markdown
Contributor

Heed the comment to not use fields of a Reference after calling its
finalize callback, because such a call may destroy the Reference.

Fixes: #19673

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x node-api Issues and PRs related to the Node-API. labels Apr 1, 2018
cjihrig approved these changes Apr 1, 2018
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but a test for this would be really nice.

n-api: back up env before finalize
225dbeb 
Heed the comment to not use fields of a Reference after calling its
finalize callback, because such a call may destroy the Reference.

Fixes: nodejs#19673

gabrielschulhof commented Apr 2, 2018

Copy link
Copy Markdown
Contributor Author

@cjihrig I updated a test to check this code path as well.

cjihrig commented Apr 2, 2018

Copy link
Copy Markdown
Contributor

Great, thanks!

gabrielschulhof commented Apr 2, 2018

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/13988/

gabrielschulhof mentioned this pull request Apr 3, 2018
Closed

gabrielschulhof commented Apr 3, 2018

Copy link
Copy Markdown
Contributor Author

I believe the CI failures are unrelated.

gabrielschulhof commented Apr 3, 2018

Copy link
Copy Markdown
Contributor Author

Landed in 1a5a19d.

gabrielschulhof pushed a commit that referenced this pull request Apr 3, 2018
n-api: back up env before finalize
1a5a19d 
Heed the comment to not use fields of a Reference after calling its
finalize callback, because such a call may destroy the Reference.

Fixes: #19673
PR-URL: #19718
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gabrielschulhof deleted the n-api-back-up-env branch April 3, 2018 13:39
targos pushed a commit that referenced this pull request Apr 3, 2018
n-api: back up env before finalize
a0a5873 
Heed the comment to not use fields of a Reference after calling its
finalize callback, because such a call may destroy the Reference.

Fixes: #19673
PR-URL: #19718
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos mentioned this pull request Apr 4, 2018
Merged
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 12, 2018
n-api: back up env before finalize
e3a2737 
Heed the comment to not use fields of a Reference after calling its
finalize callback, because such a call may destroy the Reference.

Fixes: nodejs#19673
PR-URL: nodejs#19718
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
n-api: back up env before finalize
dc4c825 
Heed the comment to not use fields of a Reference after calling its
finalize callback, because such a call may destroy the Reference.

Fixes: nodejs#19673
PR-URL: nodejs#19718
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
n-api: back up env before finalize
abd9fd6 
Heed the comment to not use fields of a Reference after calling its
finalize callback, because such a call may destroy the Reference.

Fixes: #19673
Backport-PR-URL: #19447
PR-URL: #19718
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Apr 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 1, 2018
n-api: back up env before finalize
8b3ef46 
Heed the comment to not use fields of a Reference after calling its
finalize callback, because such a call may destroy the Reference.

Fixes: #19673
Backport-PR-URL: #19265
PR-URL: #19718
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request May 2, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

n-api - failure in node-addon-api testing after change in node core

4 participants

Back | FazBrowse Home | New Git URL