net,http2: merge write error handling & property names - #19734
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Merge error handling for `net.Socket`s and `Http2Stream`s, and align the callback property names as `callback`. Refs: nodejs#19060
lpinca
approved these changes
Apr 1, 2018
tniessen
approved these changes
Apr 1, 2018
jasnell
approved these changes
Apr 1, 2018
aks-
approved these changes
Apr 2, 2018
mcollina
approved these changes
Apr 3, 2018
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
trivikr
approved these changes
Apr 10, 2018
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
addaleax
added a commit
that referenced
this pull request
Apr 12, 2018
Merge error handling for `net.Socket`s and `Http2Stream`s, and align the callback property names as `callback`. Refs: #19060 PR-URL: #19734 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
Merge error handling for `net.Socket`s and `Http2Stream`s, and align the callback property names as `callback`. Refs: #19060 PR-URL: #19734 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
Merge error handling for `net.Socket`s and `Http2Stream`s, and align the callback property names as `callback`. Refs: nodejs#19060 PR-URL: nodejs#19734 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
4 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge error handling for net.Sockets and Http2Streams,
and align the callback property names as callback.
Refs: #19060
(This has become possible after #19551)
Checklist
/cc fyi @aks-