build: make lint-ci work properly on Linux make - #19746
Conversation
Sorry, something went wrong.
|
and /cc @nodejs/build |
Sorry, something went wrong.
I didn't know that we run linters on FreeBSD so yeah, this is probably just a quirk of gmake on FreeBSD. |
Sorry, something went wrong.
PR-URL: #19746 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Looks like the commit sha is not posted here: c5928ab |
Sorry, something went wrong.
PR-URL: nodejs#19746 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
Backporting this. Let's hope it's not a problem. |
Sorry, something went wrong.
PR-URL: nodejs#19746 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #19746 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
@ryzokuken thanks for the backport on this, would you mind having a go for 6.x too? once we get full coverage of all of the active branches then we can properly implement changes in CI. |
Sorry, something went wrong.
PR-URL: #19746 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
I want to ditch the FreeBSD 10 machines from running node-test-lint and just get the jenkins-workspace machines to do it. Unfortunately it doesn't work because it seems we're using a quirk of gmake that ships with FreeBSD 10.
$(wildcard test/addons/??_*/*.cc test/addons/??_*/*.h) is executed when Makefile is loaded, and before the body of lint-addon-docs is executed. So in a pristine clone it expands to nothing, since those files are created by test/addons/.docbuildstamp which is a direct dependency of lint-addon-docs (it'd probably be OK if that was done before the call to $(MAKE) lint-addon-docs but then make lint-addon-docs as a stand-alone wouldn't work).
/cc @bnoordhuis who last tried to touch this stuff when attempting a refactor in d9b59de which was subsequently reverted
/cc @joyeecheung who introduced part of this functionality in #16377 and may have more of a clue than me about why this only seems to work on the FreeBSD 10 linter hosts