FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v8.x backport] doc: fix various nits by vsemozhetbyt · Pull Request #19753 · nodejs/node · GitHub

/ node Public

[v8.x backport] doc: fix various nits - #19753

Closed
vsemozhetbyt wants to merge 5 commits into
nodejs:v8.x-stagingfrom
vsemozhetbyt:backport-19743-to-v8.x
Closed

[v8.x backport] doc: fix various nits#19753
vsemozhetbyt wants to merge 5 commits into
nodejs:v8.x-stagingfrom
vsemozhetbyt:backport-19743-to-v8.x

Conversation

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Backport of #19743 (proactive).

Commit 1: replace 2 hyphens (--) by spaced m-dash (—) as per STYLE_GUIDE.md.
Commit 2: space infix operators.
Commit 3: unify quotes in inline code spans (use only single quotes).
Commit 4: unify * Returns: (eliminate deviations).
Commit 5: dedupe spaces.

nodejs-github-bot added doc Issues and PRs related to the documentations. v8.x labels Apr 2, 2018

Copy link
Copy Markdown
Contributor Author

Refs: #19743 (review)

vsemozhetbyt mentioned this pull request Apr 2, 2018
3 tasks

Copy link
Copy Markdown
Contributor Author

vsemozhetbyt commented Apr 4, 2018
edited
Loading

Copy link
Copy Markdown
Contributor Author

I've copied the landed PR metadata in the first commit and reword titles in the other commits to hint fixup.

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/420/

* Replace 2 hyphens (--) by spaced m-dashes (—) as per STYLE_GUIDE.md.
* Space infix operators.
* Unify quotes in inline code spans (use only single quotes).
* Unify `* Returns:` (eliminate deviations).
* Dedupe spaces.

PR-URL: #19743
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
vsemozhetbyt added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 10, 2018
gibfahn pushed a commit that referenced this pull request Apr 11, 2018
* Replace 2 hyphens (--) by spaced m-dashes (—) as per STYLE_GUIDE.md.
* Space infix operators.
* Unify quotes in inline code spans (use only single quotes).
* Unify `* Returns:` (eliminate deviations).
* Dedupe spaces.

PR-URL: #19743
Backport-PR-URL: #19753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

gibfahn commented Apr 12, 2018

Copy link
Copy Markdown
Member

Landed in c897815

gibfahn closed this Apr 12, 2018
vsemozhetbyt deleted the backport-19743-to-v8.x branch April 12, 2018 00:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL