FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add mafintosh to collaborators by mafintosh · Pull Request #19773 · nodejs/node · GitHub

/ node Public

doc: add mafintosh to collaborators - #19773

Closed
mafintosh wants to merge 1 commit into
nodejs:masterfrom
mafintosh:add-mafintosh
Closed

doc: add mafintosh to collaborators#19773
mafintosh wants to merge 1 commit into
nodejs:masterfrom
mafintosh:add-mafintosh

Conversation

Copy link
Copy Markdown
Member
Checklist

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 3, 2018

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🎉

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🎉

mafintosh changed the title Add mafintosh to collaborators doc: add mafintosh to collaborators Apr 3, 2018
trivikr added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 3, 2018

Copy link
Copy Markdown
Member Author

trivikr removed the fast-track PRs that do not need to wait for 48 hours to land. label Apr 3, 2018

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

vsemozhetbyt added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 3, 2018

Copy link
Copy Markdown
Member Author

Landed in d54f651

mafintosh closed this Apr 3, 2018
mafintosh deleted the add-mafintosh branch April 3, 2018 16:40
mafintosh added a commit that referenced this pull request Apr 3, 2018
PR-URL: #19773
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Apr 3, 2018
targos pushed a commit that referenced this pull request Apr 3, 2018
PR-URL: #19773
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos mentioned this pull request Apr 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants


Back | FazBrowse Home | New Git URL