assert: fix actual & expected input - #19925
Closed
BridgeAR wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This makes sure the actual and expected values on the error thrown by `assert.throws` etc. are always as they should be.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Many of the failures seem related to #18994 |
Sorry, something went wrong.
mcollina
approved these changes
Apr 12, 2018
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Can you rebase? The CI failures should be solved. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
New CI as requested: https://ci.nodejs.org/job/node-test-pull-request/14223/ |
Sorry, something went wrong.
trivikr
approved these changes
Apr 12, 2018
jasnell
approved these changes
Apr 12, 2018
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 13, 2018
This makes sure the actual and expected values on the error thrown by `assert.throws` etc. are always as they should be. PR-URL: nodejs#19925 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 16, 2018
This makes sure the actual and expected values on the error thrown by `assert.throws` etc. are always as they should be. PR-URL: #19925 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
This makes sure the actual and expected values on the error thrown by `assert.throws` etc. are always as they should be. PR-URL: nodejs#19925 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure the actual and expected values on the error thrown
by assert.throws etc. are always as they should be.
Checklist