timers: call destroy on interval error - #20001
Closed
apapirovski wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
When an interval callback throws an error, the destroy hook is never called due to a faulty if condition.
Copy link
Copy Markdown
Contributor
Author
|
/cc @mcollina @Fishrock123 @nodejs/timers |
Sorry, something went wrong.
3 tasks
benjamingr
approved these changes
Apr 13, 2018
BridgeAR
approved these changes
Apr 13, 2018
Comment thread
test/async-hooks/test-timers.setInterval.js
Outdated
| } | ||
|
|
||
| process.on('uncaughtException', common.mustCall((err) => { | ||
| assert(err.message, 'setInterval Error'); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This seems to miss .strictEqual.
Sorry, something went wrong.
Comment thread
test/async-hooks/test-timers.setInterval.js
Outdated
| const hooks = initHooks(); | ||
| hooks.enable(); | ||
|
|
||
| // install first timeout |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nit: please always use capital letters for the first character of a comment and use punctuation.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Was left over from another test for async hooks. It's not a very helpful comment to be honest. Removing.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Updated. Another CI: https://ci.nodejs.org/job/node-test-pull-request/14248/ |
Sorry, something went wrong.
mcollina
approved these changes
Apr 13, 2018
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
jasnell
approved these changes
Apr 13, 2018
trivikr
approved these changes
Apr 14, 2018
Fishrock123
approved these changes
Apr 16, 2018
apapirovski
added a commit
that referenced
this pull request
Apr 17, 2018
When an interval callback throws an error, the destroy hook is never called due to a faulty if condition. PR-URL: #20001 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 17, 2018
When an interval callback throws an error, the destroy hook is never called due to a faulty if condition. PR-URL: #20001 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an interval callback throws an error, the destroy hook is never called due to a faulty if condition.
This change can be backported unlike the semver-major one in the next PR which would bring us in line with the browsers (and the spec).
CI: https://ci.nodejs.org/job/node-test-pull-request/14244/
Checklist