| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Please, add 👍 here to approve fast-tracking. |
Sorry, something went wrong.
Sorry, something went wrong.
PR-URL: #20087 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
PR-URL: #20087 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
| Back | FazBrowse Home | New Git URL |
Checklist
This is the same tricky case as described in #19913, I've somehow missed it then.
Too common link reference in cli.md corrupts heading from string_decoder.md in assembled all.html (markdown references seem to be case-insensitive).
Compare: stringDecoder.end([buffer]) in string_decoder.html and stringDecoder.end(buffer) in all.html with buffer parameter made mandatory and linkified.
I've checked all the headings in all.html for any additional child HTML elements except expected (code and span with # TOC links) and found only this anomaly plus nits addressed in #20086. So, for now, there are no more similar issues.
However, I do not know how we can prevent this false linkification and parameter corruption in the future. I can think of these options at least:
cc @nodejs/documentation to consider this.
Also in passing: