@richardlau done.

Looks like real failures 😢

16:20:18 ../test/cctest/test-cpu-profiler.cc:1672:29: error: no member named 'use_optimizer' in 'v8::internal::Isolate'
16:20:18   if (!CcTest::i_isolate()->use_optimizer() || i::FLAG_always_opt) return;
16:20:18        ~~~~~~~~~~~~~~~~~~~  ^
16:20:18 ../test/cctest/test-cpu-profiler.cc:1677:3: error: unknown type name 'ProfilerHelper'
16:20:18   ProfilerHelper helper(env);

Another attempt after additional fixup: V8 CI:

• https://ci.nodejs.org/job/node-test-commit-v8-linux/1334/
• https://ci.nodejs.org/job/node-test-commit-v8-linux/1338/
• https://ci.nodejs.org/job/node-test-commit-v8-linux/1341/
• https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1342/

Okay, so the test compiles now, but right now I am playing whackamole with how CrankShaft ends up being different from TurboFan and the various different ways the profiles different at runtime.

As a starting point, CrankShaft is unable to inline functions with let in them, so that why we needed precise line numbers in d4e7d4c.

There is a second round of failure (missing script id for alpha) on the test that I need to look into.

Ping @ofrobots

@ofrobots are you still interested in this PR or can it be closed?

Abandoning. This is not worth pursing at this point.