FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: DTrace is enabled by default on darwin by evanlucas · Pull Request #2019 · nodejs/node · GitHub

/ node Public

build: DTrace is enabled by default on darwin - #2019

Merged
evanlucas merged 1 commit into
nodejs:masterfrom
evanlucas:dtrace_config
Jun 23, 2015
Merged

build: DTrace is enabled by default on darwin#2019
evanlucas merged 1 commit into
nodejs:masterfrom
evanlucas:dtrace_config

Conversation

Copy link
Copy Markdown
Contributor

In configure, the --with-dtrace option only showed that it was true by
default on sunos. It is also true by default on darwin.

mscdex added the build Issues and PRs related to build files or the CI. label Jun 19, 2015

rvagg commented Jun 21, 2015

Copy link
Copy Markdown
Member

/cc @nodejs/build

Copy link
Copy Markdown
Member

LGTM

In configure, the --with-dtrace option only showed that it was true by
default on sunos. It is also true by default on darwin.

PR-URL: nodejs#2019
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
evanlucas closed this Jun 23, 2015
evanlucas deleted the dtrace_config branch June 23, 2015 16:28
evanlucas merged commit 834a365 into nodejs:master Jun 23, 2015

Copy link
Copy Markdown
Contributor Author

Landed in 834a365. Thanks!

rvagg mentioned this pull request Jun 30, 2015
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
In configure, the --with-dtrace option only showed that it was true by
default on sunos. It is also true by default on darwin.

PR-URL: nodejs#2019
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL