FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update pull request template in the contributing guide by Hackzzila · Pull Request #20277 · nodejs/node · GitHub

/ node Public

doc: update pull request template in the contributing guide - #20277

Closed
Hackzzila wants to merge 1 commit into
nodejs:masterfrom
Hackzzila:patch-3
ConversationCommits (1)ChecksFiles changed
Closed

doc: update pull request template in the contributing guide#20277
Hackzzila wants to merge 1 commit into
nodejs:masterfrom
Hackzzila:patch-3

Conversation

Hackzzila commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

Refs: #19125

Updates the Pull Request template in the contributing guide to be consistent with .github/PULL_REQUEST_TEMPLATE.md

Checklist

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 25, 2018
tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 25, 2018

vsemozhetbyt commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

Please, add 👍 here to approve fast-tracking.

vsemozhetbyt commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/584/

vsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Apr 25, 2018

tniessen commented Apr 25, 2018

Copy link
Copy Markdown
Member

Landed in a3231d9, thank you!

tniessen closed this Apr 25, 2018
tniessen pushed a commit that referenced this pull request Apr 25, 2018
doc: update pull request template in guide
a3231d9 
PR-URL: #20277
Refs: #19125
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Hackzzila deleted the patch-3 branch April 25, 2018 14:52
MylesBorins pushed a commit that referenced this pull request May 4, 2018
doc: update pull request template in guide
3bf736e 
PR-URL: #20277
Refs: #19125
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request May 8, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
tniessen tniessen approved these changes
+1 more reviewer
vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL