FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

n-api,test: remove superfluous persistent by gabrielschulhof · Pull Request #20299 · nodejs/node · GitHub

/ node Public

n-api,test: remove superfluous persistent - #20299

Closed
gabrielschulhof wants to merge 1 commit into
nodejs:masterfrom
gabrielschulhof:n-api-clean-up-constructor-test
Closed

n-api,test: remove superfluous persistent#20299
gabrielschulhof wants to merge 1 commit into
nodejs:masterfrom
gabrielschulhof:n-api-clean-up-constructor-test

Conversation

Copy link
Copy Markdown
Contributor

Remove a superfluos persistent from test_constructor_name.c.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Remove a superfluos persistent from test_constructor_name.c.
nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Apr 25, 2018

Copy link
Copy Markdown
Member

BridgeAR added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 26, 2018
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 26, 2018
Remove a superfluos persistent from test_constructor_name.c.

PR-URL: nodejs#20299
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gabrielschulhof deleted the n-api-clean-up-constructor-test branch April 26, 2018 15:19
MylesBorins pushed a commit that referenced this pull request May 4, 2018
Remove a superfluos persistent from test_constructor_name.c.

PR-URL: #20299
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request May 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL