FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

n-api: update cli documentation by gabrielschulhof · Pull Request #20301 · nodejs/node · GitHub

/ node Public

n-api: update cli documentation - #20301

Closed
gabrielschulhof wants to merge 1 commit into
nodejs:masterfrom
gabrielschulhof:n-api-update-cli-docs
ConversationCommits (1)ChecksFiles changed
Closed

n-api: update cli documentation#20301
gabrielschulhof wants to merge 1 commit into
nodejs:masterfrom
gabrielschulhof:n-api-update-cli-docs

Conversation

gabrielschulhof commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

Fixes: #20082

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Apr 25, 2018
gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Apr 25, 2018
Trott reviewed Apr 25, 2018
View reviewed changes
Comment thread doc/api/cli.md Outdated

Trott Apr 25, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Micro-nit:

Allow Node.js to load N-API modules. This option is a no-op. It is kept for
compatibility.

Trott Apr 25, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Or maybe even better, just the last two sentences:

This option is a no-op. It is kept for compatibility.

cjihrig approved these changes Apr 25, 2018
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. I'd rather just remove it completely though.

gabrielschulhof commented Apr 25, 2018

Copy link
Copy Markdown
Contributor Author

@Trott I updated the wording as you requested.

vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 25, 2018

vsemozhetbyt commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

Please, add 👍 here to approve fast-tracking.

vsemozhetbyt commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/587/

vsemozhetbyt added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 25, 2018

richardlau commented Apr 25, 2018

Copy link
Copy Markdown
Member

I'd rather just remove it completely though.

It was previously half removed by #14902 but #19878 put them back.

gabrielschulhof commented Apr 26, 2018

Copy link
Copy Markdown
Contributor Author

Landed in 24c8f0b.

gabrielschulhof pushed a commit that referenced this pull request Apr 26, 2018
n-api: update cli documentation
24c8f0b 
Fixes: #20082
PR-URL: #20301
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
gabrielschulhof deleted the n-api-update-cli-docs branch April 26, 2018 15:20
MylesBorins pushed a commit that referenced this pull request May 4, 2018
n-api: update cli documentation
8d24b6e 
Fixes: #20082
PR-URL: #20301
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins mentioned this pull request May 8, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
trivikr trivikr approved these changes
+1 more reviewer
vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

documentation of --napi-modules

8 participants

Back | FazBrowse Home | New Git URL