FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: remove os.uptime() Windows note by cjihrig · Pull Request #20308 · nodejs/node · GitHub

/ node Public

doc: remove os.uptime() Windows note - #20308

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:os-uptime
Closed

doc: remove os.uptime() Windows note#20308
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:os-uptime

Conversation

cjihrig commented Apr 25, 2018

Copy link
Copy Markdown
Contributor

The libuv 1.20.2 update in Node 10 aligned the Windows behavior of os.uptime() with that of other operating systems. The return value no longer contains a fraction component.

Refs: #20129

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

The libuv 1.20.2 update in Node 10 aligned the Windows behavior
of os.uptime() with that of other operating systems. The return
value no longer contains a fraction component.

Refs: nodejs#20129
nodejs-github-bot added doc Issues and PRs related to the documentations. os Issues and PRs related to the os subsystem. labels Apr 25, 2018
vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 25, 2018

Copy link
Copy Markdown
Contributor

Please, add 👍 here to approve fast-tracking.

Copy link
Copy Markdown
Contributor

vsemozhetbyt added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 25, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Apr 26, 2018
The libuv 1.20.2 update in Node 10 aligned the Windows behavior
of os.uptime() with that of other operating systems. The return
value no longer contains a fraction component.

Refs: nodejs#20129

PR-URL: nodejs#20308
Refs: nodejs#20129
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Copy link
Copy Markdown
Member

Landed in 124875c 🎉

BridgeAR closed this Apr 26, 2018
cjihrig deleted the os-uptime branch April 29, 2018 10:06
MylesBorins pushed a commit that referenced this pull request May 4, 2018
The libuv 1.20.2 update in Node 10 aligned the Windows behavior
of os.uptime() with that of other operating systems. The return
value no longer contains a fraction component.

Refs: #20129

PR-URL: #20308
Refs: #20129
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins mentioned this pull request May 8, 2018
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
The libuv 1.20.2 update in Node 10 aligned the Windows behavior
of os.uptime() with that of other operating systems. The return
value no longer contains a fraction component.

Refs: #20129

PR-URL: #20308
Refs: #20129
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins mentioned this pull request Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. os Issues and PRs related to the os subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL