FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: clarify prerequisites in benchmark/README.md by Fishrock123 · Pull Request #2034 · nodejs/node · GitHub

/ node Public

doc: clarify prerequisites in benchmark/README.md - #2034

Merged
Fishrock123 merged 1 commit into
nodejs:masterfrom
Fishrock123:clarify-benchmark-prerequisites
Jun 24, 2015
Merged

doc: clarify prerequisites in benchmark/README.md#2034
Fishrock123 merged 1 commit into
nodejs:masterfrom
Fishrock123:clarify-benchmark-prerequisites

Conversation

Copy link
Copy Markdown
Contributor

i.e. neither of these are available via apt-get, and people won't necessarily know how they might get them otherwise. (Or that "ab" stands for ApacheBench.)

Fishrock123 added doc Issues and PRs related to the documentations. benchmark Issues and PRs related to the benchmark subsystem. labels Jun 23, 2015

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment

Copy link
Copy Markdown
Contributor

LGTM

PR-URL: nodejs#2034
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Fishrock123 force-pushed the clarify-benchmark-prerequisites branch from d2b21c4 to dbd5dc9 Compare June 24, 2015 16:58
Fishrock123 merged commit dbd5dc9 into nodejs:master Jun 24, 2015
rvagg mentioned this pull request Jun 30, 2015
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
PR-URL: nodejs#2034
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark Issues and PRs related to the benchmark subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL