FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove unnecessary strictEqual() argument from remoteClose() by dayloryanes · Pull Request #20343 · nodejs/node · GitHub

/ node Public

test: remove unnecessary strictEqual() argument from remoteClose() - #20343

Closed
dayloryanes wants to merge 1 commit into
nodejs:masterfrom
dayloryanes:test/http-agent-keepalive
ConversationCommits (1)ChecksFiles changed
Closed

test: remove unnecessary strictEqual() argument from remoteClose()#20343
dayloryanes wants to merge 1 commit into
nodejs:masterfrom
dayloryanes:test/http-agent-keepalive

Conversation

dayloryanes commented Apr 26, 2018

Copy link
Copy Markdown
Contributor

On the remoteClose() test, removing the string literal message on the third argument from assert.strictEqual(), allows for the value of agent.freeSockets[name] to get printed.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

cc: @Trott

nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 26, 2018

Trott commented Apr 26, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/14534/

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 26, 2018

Trott commented Apr 26, 2018

Copy link
Copy Markdown
Member

CI re-runs for three (!) platforms:

https://ci.nodejs.org/job/node-test-commit-arm-fanned/795/
https://ci.nodejs.org/job/node-test-binary-windows/16865/
https://ci.nodejs.org/job/node-test-commit-linux/18321/

Trott commented Apr 27, 2018

Copy link
Copy Markdown
Member

Welp...let's re-run again:

https://ci.nodejs.org/job/node-test-commit-linux/18351/
https://ci.nodejs.org/job/node-test-binary-windows/16897/
https://ci.nodejs.org/job/node-test-commit-arm-fanned/826/

Trott commented Apr 29, 2018

Copy link
Copy Markdown
Member

OK, two CI re-runs:

https://ci.nodejs.org/job/node-test-commit-arm-fanned/866/
https://ci.nodejs.org/job/node-test-commit-windows-fanned/17630/

trivikr commented May 3, 2018

Copy link
Copy Markdown
Member

Another CI-rerun for node-test-commit-windows-fanned https://ci.nodejs.org/job/node-test-commit-windows-fanned/17709/

trivikr commented May 3, 2018

Copy link
Copy Markdown
Member

Landed in aa18e22

Congratulations @dayloryanes on your first commit in Node.js core! 🎉 🎉 🎉

trivikr pushed a commit that referenced this pull request May 3, 2018
test: remove unnecessary strictEqual() argument from remoteClose()
aa18e22 
PR-URL: #20343
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
trivikr closed this May 3, 2018
MylesBorins pushed a commit that referenced this pull request May 4, 2018
test: remove unnecessary strictEqual() argument from remoteClose()
3d2a7fe 
PR-URL: #20343
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

jasnell commented May 5, 2018

Copy link
Copy Markdown
Member

Landed is merged. we don't use the big green button to merge for a number of reasons. This will go out in an upcoming 10.x

dayloryanes commented May 5, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thank you @jasnell for the clarification.

MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
test: remove unnecessary strictEqual() argument from remoteClose()
b24ee07 
PR-URL: #20343
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL