FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: check for error on Windows by Trott · Pull Request #2035 · nodejs/node · GitHub

/ node Public

test: check for error on Windows - #2035

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:dgram-windows
ConversationCommits (1)ChecksFiles changed
Closed

test: check for error on Windows#2035
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:dgram-windows

Conversation

Trott commented Jun 23, 2015

Copy link
Copy Markdown
Member

Instead of not running the dgram-bind-shared-ports
on Windows, check that it gets ENOTSUP.

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/70/

Trott added dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests. labels Jun 23, 2015
brendanashworth added the windows Issues and PRs related to the Windows platform. label Jun 23, 2015
bnoordhuis reviewed Jun 23, 2015
View reviewed changes
Comment thread test/parallel/test-dgram-bind-shared-ports.js Outdated

bnoordhuis Jun 23, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe wrap the callback in common.mustCall(...)?

bnoordhuis commented Jun 23, 2015

Copy link
Copy Markdown
Member

LGTM with a suggestion. Can you remove the console.log statements?

cjihrig reviewed Jun 23, 2015
View reviewed changes
Comment thread test/parallel/test-dgram-bind-shared-ports.js Outdated

cjihrig Jun 23, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You can use common.isWindows here.

cjihrig commented Jun 23, 2015

Copy link
Copy Markdown
Contributor

I agree about the console.log()s. They can be useful when a test fails and you're looking at the output, but two generic oks aren't very helpful.

test: check for error on Windows
7858a3e 
Instead of not running the dgram-bind-shared-ports
on Windows, check that it gets ENOTSUP.

Trott commented Jun 23, 2015

Copy link
Copy Markdown
Member Author

Per feedback from @bnoordhuis and @cjihrig:

  • Use common.isWindows rather than rolling my own
  • Use common.mustCall() to insure callback gets called exactly once
  • Remove less-than-informative console.log() messages

New CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/71/

Trott commented Jun 23, 2015

Copy link
Copy Markdown
Member Author

Yet another CI to confirm that the smartOS failure was a flaky test and not something in this PR:

https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/72/

cjihrig commented Jun 23, 2015

Copy link
Copy Markdown
Contributor

Yea, this PR only changes a test, so unless test-dgram-bind-shared-ports.js fails, it's most likely unrelated. LGTM if the CI is happy.

bnoordhuis reviewed Jun 23, 2015
View reviewed changes
Comment thread test/parallel/test-dgram-bind-shared-ports.js

bnoordhuis Jun 23, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

1 is the default, you can just write it as worker1.on('error', common.mustCall(function(err) { (although it's not wrong this way.)

bnoordhuis commented Jun 23, 2015

Copy link
Copy Markdown
Member

LGTM

Trott commented Jun 23, 2015

Copy link
Copy Markdown
Member Author

Third time is the charm on the CI run. All green: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/73/

Trott added a commit that referenced this pull request Jun 25, 2015
test: check for error on Windows
8e9089a 
Instead of not running the dgram-bind-shared-ports
on Windows, check that it gets ENOTSUP.

PR-URL: #2035
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Trott commented Jun 25, 2015

Copy link
Copy Markdown
Member Author

Merged in 8e9089a

Trott closed this Jun 25, 2015
rvagg mentioned this pull request Jun 30, 2015
Closed
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
test: check for error on Windows
4600250 
Instead of not running the dgram-bind-shared-ports
on Windows, check that it gets ENOTSUP.

PR-URL: nodejs#2035
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott deleted the dgram-windows branch January 9, 2022 22:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL